From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4343CC5ACAE for ; Thu, 12 Sep 2019 07:01:43 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A7C820830 for ; Thu, 12 Sep 2019 07:01:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="rJhsullp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A7C820830 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EFC1B1713; Thu, 12 Sep 2019 09:00:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EFC1B1713 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1568271700; bh=IS1/YyUj1XT7bs4hiBnxl6p3/5iiSwjuI1C3XpJNCN8=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=rJhsullptnwxMem8C1BSOsAYdzWb7XdJSKEYQQUbzZR0G0kcTKBB9DDR44vrK3Xy7 0LZ1LNU49iBTCE2Gyl4RQlpcXC5Zb011CyhCWJD49wr7yMfPVxyicA5J62aXRdmD+m EhgRCZsHZchIMne/04b1xhDu7Ahw6R6X9AuqC27s= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6F475F802DF; Thu, 12 Sep 2019 09:00:49 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D245EF80368; Thu, 12 Sep 2019 09:00:47 +0200 (CEST) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 417A0F802DF for ; Thu, 12 Sep 2019 09:00:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 417A0F802DF X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 99AEAAF5B; Thu, 12 Sep 2019 07:00:43 +0000 (UTC) Date: Thu, 12 Sep 2019 09:00:43 +0200 Message-ID: From: Takashi Iwai To: Brent Lu In-Reply-To: <1567733058-9561-1-git-send-email-brent.lu@intel.com> References: <1567733058-9561-1-git-send-email-brent.lu@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org, kuninori.morimoto.gx@renesas.com, yang.jie@linux.intel.com, cezary.rojewski@intel.com, pierre-louis.bossart@linux.intel.com, liam.r.girdwood@linux.intel.com, broonie@kernel.org, tglx@linutronix.de Subject: Re: [alsa-devel] [PATCH] ASoC: bdw-rt5677: channel constraint support X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 06 Sep 2019 03:24:18 +0200, Brent Lu wrote: > > BDW boards using this machine driver supports only stereo capture and > playback. Implement a constraint to enforce it. > > Signed-off-by: Brent Lu > --- > sound/soc/intel/boards/bdw-rt5677.c | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/sound/soc/intel/boards/bdw-rt5677.c b/sound/soc/intel/boards/bdw-rt5677.c > index 4a4d335..a312b55 100644 > --- a/sound/soc/intel/boards/bdw-rt5677.c > +++ b/sound/soc/intel/boards/bdw-rt5677.c > @@ -22,6 +22,8 @@ > > #include "../../codecs/rt5677.h" > > +#define DUAL_CHANNEL 2 > + > struct bdw_rt5677_priv { > struct gpio_desc *gpio_hp_en; > struct snd_soc_component *component; > @@ -245,6 +247,36 @@ static int bdw_rt5677_init(struct snd_soc_pcm_runtime *rtd) > return 0; > } > > +static const unsigned int channels[] = { > + DUAL_CHANNEL, > +}; > + > +static const struct snd_pcm_hw_constraint_list constraints_channels = { > + .count = ARRAY_SIZE(channels), > + .list = channels, > + .mask = 0, > +}; > + > +static int bdw_fe_startup(struct snd_pcm_substream *substream) > +{ > + struct snd_pcm_runtime *runtime = substream->runtime; > + > + /* > + * On this platform for PCM device we support, > + * stereo > + */ > + > + runtime->hw.channels_max = DUAL_CHANNEL; > + snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS, > + &constraints_channels); Can't we simply set both channels_min and channels_max to 2? thanks, Takashi > + > + return 0; > +} > + > +static const struct snd_soc_ops bdw_rt5677_fe_ops = { > + .startup = bdw_fe_startup, > +}; > + > /* broadwell digital audio interface glue - connects codec <--> CPU */ > SND_SOC_DAILINK_DEF(dummy, > DAILINK_COMP_ARRAY(COMP_DUMMY())); > @@ -273,6 +305,7 @@ static struct snd_soc_dai_link bdw_rt5677_dais[] = { > }, > .dpcm_capture = 1, > .dpcm_playback = 1, > + .ops = &bdw_rt5677_fe_ops, > SND_SOC_DAILINK_REG(fe, dummy, platform), > }, > > -- > 2.7.4 > > _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel