From: Takashi Iwai <tiwai@suse.de>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 2/2] ALSA: ac97: add codecs devicetree binding
Date: Thu, 21 Jun 2018 21:45:46 +0200 [thread overview]
Message-ID: <s5ha7rnditx.wl-tiwai@suse.de> (raw)
In-Reply-To: <20180621154356.5438-2-robert.jarzmik@free.fr>
On Thu, 21 Jun 2018 17:43:56 +0200,
Robert Jarzmik wrote:
>
> Add a devicetree binding for codecs. This is especially useful if the
> AC97 bitclk clock is provided by the codec, as it has to be described in
> the devicetree description for the ac97 bus code to aquire it.
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
> Special review query: review the "return of_node_get(node)", which
> assumes that upon device removal, of_put_node(dev.of_node) will be
> called...
Is it really done automagically? I couldn't spot it.
thanks,
Takashi
next prev parent reply other threads:[~2018-06-21 19:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 15:43 [PATCH 1/2] ALSA: ac97: add bus binding for codecs Robert Jarzmik
2018-06-21 15:43 ` [PATCH 2/2] ALSA: ac97: add codecs devicetree binding Robert Jarzmik
2018-06-21 19:45 ` Takashi Iwai [this message]
2018-06-22 10:41 ` Robert Jarzmik
2018-06-22 10:49 ` Takashi Iwai
2018-06-22 14:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5ha7rnditx.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robert.jarzmik@free.fr \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).