From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 2/2] ALSA: ac97: add codecs devicetree binding Date: Thu, 21 Jun 2018 21:45:46 +0200 Message-ID: References: <20180621154356.5438-1-robert.jarzmik@free.fr> <20180621154356.5438-2-robert.jarzmik@free.fr> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id D48C22676C4 for ; Thu, 21 Jun 2018 21:45:47 +0200 (CEST) In-Reply-To: <20180621154356.5438-2-robert.jarzmik@free.fr> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Robert Jarzmik Cc: Mark Rutland , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Liam Girdwood , Rob Herring , Mark Brown List-Id: alsa-devel@alsa-project.org On Thu, 21 Jun 2018 17:43:56 +0200, Robert Jarzmik wrote: > > Add a devicetree binding for codecs. This is especially useful if the > AC97 bitclk clock is provided by the codec, as it has to be described in > the devicetree description for the ac97 bus code to aquire it. > > Signed-off-by: Robert Jarzmik > --- > Special review query: review the "return of_node_get(node)", which > assumes that upon device removal, of_put_node(dev.of_node) will be > called... Is it really done automagically? I couldn't spot it. thanks, Takashi