From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [bug report] ALSA: usb-audio: Tascam US-16x08
	DSP	mixer quirk
Date: Wed, 22 Feb 2017 22:10:08 +0100
Message-ID: <s5ha89erky7.wl-tiwai@suse.de>
References: <20170222184649.GA589@mwanda>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id AF27F266ED0
 for <alsa-devel@alsa-project.org>; Wed, 22 Feb 2017 22:10:09 +0100 (CET)
In-Reply-To: <20170222184649.GA589@mwanda>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: onkel@paraair.de, alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

On Wed, 22 Feb 2017 19:46:49 +0100,
Dan Carpenter wrote:
> 
> Hello Detlef Urban,
> 
> This is a semi-automatic email about new static checker warnings.
> 
> The patch d2bb390a2081: "ALSA: usb-audio: Tascam US-16x08 DSP mixer 
> quirk" from Feb 20, 2017, leads to the following Smatch complaint:
> 
> sound/usb/mixer_us16x08.c:716 snd_us16x08_meter_get()
> 	 warn: variable dereferenced before check 'elem' (see line 711)
> 
> sound/usb/mixer_us16x08.c
>    710		struct usb_mixer_elem_info *elem = kcontrol->private_data;
>    711		struct snd_usb_audio *chip = elem->head.mixer->chip;
>                                              ^^^^^^^^^^^^^^^^^^^^^^
> Dereference.
> 
>    712		struct snd_us16x08_meter_store *store = elem->private_data;
>    713		u8 meter_urb[64];
>    714		char tmp[max(sizeof(mix_init_msg1), sizeof(mix_init_msg2))];
>    715	
>    716		if (elem) {
>                     ^^^^
> Check.
> 
>    717			store = (struct snd_us16x08_meter_store *) elem->private_data;
>    718			chip = elem->head.mixer->chip;

Thanks for the report.
The buggy part was already removed in the later patch.


Takashi