From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] jack: Fixing a small memory leak Date: Mon, 10 Aug 2015 17:09:57 +0200 Message-ID: References: <1439218706-30721-1-git-send-email-corfuvalentin@gmail.com> <1439218706-30721-2-git-send-email-corfuvalentin@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 3DCF226598D for ; Mon, 10 Aug 2015 17:09:57 +0200 (CEST) In-Reply-To: <1439218706-30721-2-git-send-email-corfuvalentin@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Valentin Corfu Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Mon, 10 Aug 2015 16:58:26 +0200, Valentin Corfu wrote: > > Signed-off-by: Valentin Corfu So you found out the very same fix :) But please put more description in the commit log. For example, the valgrind output you cited would be a good material. thanks, Takashi > --- > jack/pcm_jack.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/jack/pcm_jack.c b/jack/pcm_jack.c > index 568ec43..de9c46e 100644 > --- a/jack/pcm_jack.c > +++ b/jack/pcm_jack.c > @@ -103,6 +103,7 @@ static void snd_pcm_jack_free(snd_pcm_jack_t *jack) > if (jack->io.poll_fd >= 0) > close(jack->io.poll_fd); > free(jack->areas); > + free(jack->ports); > free(jack); > } > } > -- > 1.9.1 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >