From: Takashi Iwai <tiwai@suse.de>
To: Maarten Baert <maarten-baert@hotmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] Use jack_client_open instead of deprecated jack_client_new.
Date: Wed, 19 Mar 2014 16:57:55 +0100 [thread overview]
Message-ID: <s5ha9cmmb98.wl%tiwai@suse.de> (raw)
In-Reply-To: <BLU0-SMTP43AF44544297B1681F68AE27C0@phx.gbl>
At Tue, 18 Mar 2014 17:55:14 +0100,
Maarten Baert wrote:
>
> Signed-off-by: Maarten Baert <maarten-baert@hotmail.com>
Thanks, applied.
I didn't fix this in the past because of the possible build issue with
the old jack, but it should be old enough to fix. Once when we get a
bug report, we can still revert it, or make it conditional via
configure script.
Takashi
> ---
> jack/pcm_jack.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/jack/pcm_jack.c b/jack/pcm_jack.c
> index 4213708..7a8b24d 100644
> --- a/jack/pcm_jack.c
> +++ b/jack/pcm_jack.c
> @@ -370,7 +370,7 @@ static int snd_pcm_jack_open(snd_pcm_t **pcmp, const char *name,
> __func__, jack_client_name, (int)strlen(jack_client_name));
> }
>
> - jack->client = jack_client_new(jack_client_name);
> + jack->client = jack_client_open(jack_client_name, JackNoStartServer, NULL);
>
> if (jack->client == 0) {
> snd_pcm_jack_free(jack);
> --
> 1.9.0
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
prev parent reply other threads:[~2014-03-19 15:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 16:55 [PATCH] Use jack_client_open instead of deprecated jack_client_new Maarten Baert
2014-03-19 15:57 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5ha9cmmb98.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=maarten-baert@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox