From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ALSA: hda - Enable front audio jacks on one HP desktop model Date: Thu, 20 Feb 2014 08:17:19 +0100 Message-ID: References: <1392868041-21319-1-git-send-email-hui.wang@canonical.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <1392868041-21319-1-git-send-email-hui.wang@canonical.com> Sender: stable-owner@vger.kernel.org To: Hui Wang Cc: alsa-devel@alsa-project.org, david.henningsson@canonical.com, stable@vger.kernel.org, gerald.yang@canonical.com List-Id: alsa-devel@alsa-project.org At Thu, 20 Feb 2014 11:47:21 +0800, Hui Wang wrote: > > The front headphone and mic jackes on a HP desktop model (Vendor Id: > 0x111d76c7 Subsystem Id: 0x103c2b17) can not work, the codec on this > machine has 8 physical ports, 6 of them are routed to rear jackes > and all of them work very well, while the remaining 2 ports are > routed to front headphone and mic jackes, but the corresponding > pin complex node are not defined correctly. > > After apply this fix, the front audio jackes can work very well. > > BugLink: https://bugs.launchpad.net/bugs/1282369 > Cc: David Henningsson > Tested-by: Gerald Yang > Cc: stable@vger.kernel.org > Signed-off-by: Hui Wang Thanks, I applied with the additional fix below: > --- > sound/pci/hda/patch_sigmatel.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c > index 7311bad..d75f90a 100644 > --- a/sound/pci/hda/patch_sigmatel.c > +++ b/sound/pci/hda/patch_sigmatel.c > @@ -83,7 +83,8 @@ enum { > STAC_DELL_M6_BOTH, > STAC_DELL_EQ, > STAC_ALIENWARE_M17X, > - STAC_92HD73XX_MODELS > + STAC_92HD73XX_MODELS, > + STAC_92HD89XX_HP_FRONT_JACK XXX_MODELS indicate number of enum items (although they aren't referred any longer in the code), so you need to insert the new item before it. Takashi