Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Harry Butterworth <heb1001@gmail.com>
Cc: Alsa-devel@alsa-project.org
Subject: Re: Creative X-Fi Titanium HD ctxfi bugs 5378 5218 4868
Date: Fri, 03 Jun 2011 17:44:32 +0200	[thread overview]
Message-ID: <s5haady3onz.wl%tiwai@suse.de> (raw)
In-Reply-To: <BANLkTinvze9uO+ir_QXdCw4-g+E5QCoMXQ@mail.gmail.com>

At Mon, 30 May 2011 21:22:07 +0800,
Harry Butterworth wrote:
> 
> Hello folks,
> 
>     I bought an X-Fi Titanium HD thinking it would work with the ctxfi
> driver but it is a new card and has a few differences from the earlier
> cards.  Creative technical support have been quite helpful in
> answering my questions.  This email is a heads-up to let you know that
> I'm doing some work on the driver.
> 
>     I'm not finished yet.  In particular the PLL initialization still
> does not work reliably, the capture source selection is a bit broken
> and one of the ADC chips is being driven out-of-spec when the card is
> run at 192kHz.
> 
>     I have attached the current state of my changes which are enough
> to get the Titanium HD card working but the patch shouldn't be applied
> because my hack at the PLL code and a couple of other bits may break
> existing cards.  I have been working against the ALSA 1.0.24 release
> so this is a patch against 1.0.24.
> 
>     I'm waiting for creative to answer my questions about the PLL
> initialization and correct setup for 196kHz operation.  Once I get the
> answers I'll try to fix the issues and submit a cleaner patch.

Thanks for your work.  It's good to know that the model actually works
somehow indeed.

A few comment about the patch:

- Instead of adding have_dedicated_mic and have_output_switch
  callbacks in every place, I'd put some bit flags indicating the
  capabilities, and set at the initialization appropriately.
- A few easy coding-style issues; run scripts/checkpatch.pl and fix
  the errors appropriately.


thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2011-06-03 15:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-30 13:22 Creative X-Fi Titanium HD ctxfi bugs 5378 5218 4868 Harry Butterworth
2011-06-03 15:44 ` Takashi Iwai [this message]
2011-06-11 10:35   ` Harry Butterworth
2011-06-11 10:39     ` Harry Butterworth
     [not found]   ` <BANLkTinovea9fE1Hxey83W+WAiYGBv600Q@mail.gmail.com>
2011-06-12 16:48     ` Takashi Iwai
2011-06-14  5:38       ` Takashi Iwai
2011-06-14  8:23         ` Harry Butterworth
2011-06-16  0:32           ` Harry Butterworth
2011-06-16  5:30             ` Takashi Iwai
2011-06-05  4:35 ` Marshall DeBerry
     [not found] <BANLkTikkMNPZ02ZmPtrJSmSEWi8nkfXsag@mail.gmail.com>
2011-06-03 12:26 ` Harry Butterworth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5haady3onz.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=Alsa-devel@alsa-project.org \
    --cc=heb1001@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox