From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 11/15] pci: echoaudio: check kmalloc()
	result
Date: Mon, 19 Jul 2010 18:00:12 +0200
Message-ID: <s5haapnfomr.wl%tiwai@suse.de>
References: <1279296943-25187-1-git-send-email-segooon@gmail.com>
	<20100716211650.4abb6387@Jay>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
	by alsa0.perex.cz (Postfix) with ESMTP id 03EAA244F1
	for <alsa-devel@alsa-project.org>;
	Mon, 19 Jul 2010 18:00:13 +0200 (CEST)
In-Reply-To: <20100716211650.4abb6387@Jay>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Giuliano Pochini <pochini@shiny.it>
Cc: alsa-devel@alsa-project.org, Kulikov Vasiliy <segooon@gmail.com>, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Julia Lawall <julia@diku.dk>
List-Id: alsa-devel@alsa-project.org

At Fri, 16 Jul 2010 21:16:50 +0200,
Giuliano Pochini wrote:
> 
> On Fri, 16 Jul 2010 20:15:43 +0400
> Kulikov Vasiliy <segooon@gmail.com> wrote:
> 
> > If kmalloc() fails exit with -ENOMEM.
> > 
> > Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> > ---
> >  sound/pci/echoaudio/echoaudio.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c
> > index 668a5ec..20763dd 100644
> > --- a/sound/pci/echoaudio/echoaudio.c
> > +++ b/sound/pci/echoaudio/echoaudio.c
> > @@ -2250,6 +2250,8 @@ static int snd_echo_resume(struct pci_dev *pci)
> >  	DE_INIT(("resume start\n"));
> >  	pci_restore_state(pci);
> >  	commpage_bak = kmalloc(sizeof(struct echoaudio), GFP_KERNEL);
> > +	if (commpage_bak == NULL)
> > +		return -ENOMEM;
> >  	commpage = chip->comm_page;
> >  	memcpy(commpage_bak, commpage, sizeof(struct comm_page));
> >  
> 
> Yes, of course. Thank you.
> 
> 
> Ack-by: Giuliano Pochini <pochini@shiny.it>

Applied now.  Thanks.


Takashi