Re: [PATCH] sc6000: enable joystick port

[Takashi Iwai <tiwai@suse.de>]

At Fri, 24 Apr 2009 18:23:39 +0200,
Krzysztof Helt wrote:
> 
> From: Krzysztof Helt <krzysztof.h1@wp.pl>
> 
> Add module parameter to enable or disable
> joystick port (gameport) on the SC6600 and
> later cards.
> 
> Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
> ---
>  sound/isa/sc6000.c |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/isa/sc6000.c b/sound/isa/sc6000.c
> index c803b2e..7e2526a 100644
> --- a/sound/isa/sc6000.c
> +++ b/sound/isa/sc6000.c
> @@ -56,6 +56,7 @@ static long mpu_port[SNDRV_CARDS] = SNDRV_DEFAULT_PORT;
>  						/* 0x300, 0x310, 0x320, 0x330 */
>  static int mpu_irq[SNDRV_CARDS] = SNDRV_DEFAULT_IRQ;	/* 5, 7, 9, 10, 0 */
>  static int dma[SNDRV_CARDS] = SNDRV_DEFAULT_DMA;	/* 0, 1, 3 */
> +static int joystick[SNDRV_CARDS] = { [0 ... (SNDRV_CARDS-1)] = 0 };
>  
>  module_param_array(index, int, NULL, 0444);
>  MODULE_PARM_DESC(index, "Index value for sc-6000 based soundcard.");
> @@ -75,6 +76,8 @@ module_param_array(mpu_irq, int, NULL, 0444);
>  MODULE_PARM_DESC(mpu_irq, "MPU-401 IRQ # for sc-6000 driver.");
>  module_param_array(dma, int, NULL, 0444);
>  MODULE_PARM_DESC(dma, "DMA # for sc-6000 driver.");
> +module_param_array(joystick, int, NULL, 0444);

Better to be bool.

> +MODULE_PARM_DESC(dma, "Enable gameport.");

This doesn't match with the real name...

Also, don't forget to update
Documentation/sound/alsa/ALSA-Configuration.txt, too.


Could you fix and repost?

thanks,

Takashi