Re: [Alsa-devel] A: VIA Technologies Inc. VT1720/24

[Takashi Iwai <tiwai@suse.de>]

At Wed, 24 Jan 2007 13:10:40 +0100,
Philipp Matthias Hahn wrote:
> 
> From: Philipp Matthias Hahn <pmhahn@pmhahn.de>
> 
> Fix small typo in comment of Prodigy 7.1 Light
> Add support for AudioTrak Prodigt 7.1 HiFi
> 
> Signed-of-by: Philipp Matthias Hahn <pmhahn@pmhahn.de>
(snip)
>  /* entry point */
>  struct snd_ice1712_card_info snd_vt1724_aureon_cards[] __devinitdata = {
> @@ -2153,5 +2169,15 @@ struct snd_ice1712_card_info snd_vt1724_
>  		.eeprom_data = prodigy71lt_eeprom,
>  		.driver = "Prodigy71LT",
>  	},
> +	{
> +		.subvendor = VT1724_SUBDEVICE_PRODIGY71HIFI,
> +		.name = "Audiotrak Prodigy 7.1 HiFi",
> +		.model = "prodigy71hifi",
> +		.chip_init = aureon_init,
> +		.build_controls = aureon_add_controls,
> +		.eeprom_size = sizeof(prodigy71hifi_eeprom),
> +		.eeprom_data = prodigy71hifi_eeprom,
> +		.driver = "Prodigy71HiFi", /* should be identical with Prodigy71 */

I recommend you to use the same string for this driver name here.
This string is referred by alsa-lib to pick up the corresponding
config file.  As Prodigy 7.1 Hifi is almost identical with Prodigy 7.1
LT from the configuration POV, it should use "Prodigy71LT", too, so
that you don't have to change alsa-lib at all.

Otherwise changes look OK to me, but your patch conflicts with the
latest ALSA HG tree because of the patch applied prior to this.
Could you regenerate the patch to ALSA HG tree (with the fix above)?


thanks,

Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV