From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ALSA: firewire-lib: use 8 byte header for IR context to get isochronous cycle Date: Mon, 18 Mar 2019 14:52:14 +0100 Message-ID: References: <20190317112506.20243-1-o-takashi@sakamocchi.jp> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E7036F80709 for ; Mon, 18 Mar 2019 14:52:14 +0100 (CET) In-Reply-To: <20190317112506.20243-1-o-takashi@sakamocchi.jp> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Takashi Sakamoto Cc: alsa-devel@alsa-project.org, clemens@ladisch.de List-Id: alsa-devel@alsa-project.org On Sun, 17 Mar 2019 12:25:06 +0100, Takashi Sakamoto wrote: > > In kernel API of Linux FireWire subsystem, handlers of isochronous > receive (IR) context can get context headers as an argument of > callback. When 4 byte header is used, the context header includes > isochronous packet header for each packet. When 8 byte header is > used, it includes isochronous cycle as well. > > ALSA IEC 61883-1/6 engine uses 4 byte header, and computes isochronous > cycle from the cycle of interrupt. The usage of 8 byte header can > obsolete the computation. > > Furthermore, this change works well for a case that a series of > packet in one interrupt includes skipped isochronous cycle, > > This commit uses 8 byte header to handle isochronous cycle. > > Signed-off-by: Takashi Sakamoto Applied to for-next branch now. Thanks. Takashi