From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH - AAF PCM plugin 2/7] aaf: Load
	configuration parameters
Date: Wed, 10 Oct 2018 12:29:50 +0200
Message-ID: <s5hbm82xffl.wl-tiwai@suse.de>
References: <20181003234547.16839-1-andre.guedes@intel.com>
 <20181003234547.16839-3-andre.guedes@intel.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx1.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 190D82678AB
 for <alsa-devel@alsa-project.org>; Wed, 10 Oct 2018 12:29:51 +0200 (CEST)
In-Reply-To: <20181003234547.16839-3-andre.guedes@intel.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Andre Guedes <andre.guedes@intel.com>
Cc: alsa-devel@alsa-project.org, liam.r.girdwood@intel.com
List-Id: alsa-devel@alsa-project.org

On Thu, 04 Oct 2018 01:45:42 +0200,
Andre Guedes wrote:
> 
> This patch implements the infrastructure to load the plugin
> configuration from ALSA configuration file. The configuration
> is loaded in open() callback.
> 
> All configuration parameters are described in details in doc/aaf.txt
> file.
> 
> Signed-off-by: Andre Guedes <andre.guedes@intel.com>
> ---
>  aaf/pcm_aaf.c | 131 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  doc/aaf.txt   |  52 +++++++++++++++++++++++
>  2 files changed, 183 insertions(+)
> 
> diff --git a/aaf/pcm_aaf.c b/aaf/pcm_aaf.c
> index 7890e10..32db15e 100644
> --- a/aaf/pcm_aaf.c
> +++ b/aaf/pcm_aaf.c
> @@ -20,11 +20,138 @@
>  
>  #include <alsa/asoundlib.h>
>  #include <alsa/pcm_external.h>
> +#include <linux/if.h>
> +#include <linux/if_ether.h>

Ideally these standard headers should be checked in configure script.
(Not that important, though.)


thanks,

Takashi