From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [alsa-devel] [PATCH 1/4] ALSA: usb: stream: refactor audio interface parsing Date: Thu, 19 Apr 2018 11:55:37 +0200 Message-ID: References: <1523658266-2259-1-git-send-email-ruslan.bilovol@gmail.com> <1523658266-2259-2-git-send-email-ruslan.bilovol@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <1523658266-2259-2-git-send-email-ruslan.bilovol@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Ruslan Bilovol Cc: Jorge , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman List-Id: alsa-devel@alsa-project.org On Sat, 14 Apr 2018 00:24:23 +0200, Ruslan Bilovol wrote: > > Offload snd_usb_parse_audio_interface() function which > became quite long after adding UAC3 spec support. > > Move class-specific parts to separate functions > which now produce audioformat structure that is > ready to be fed to snd_usb_add_audio_stream(). > > This also broke Blue Microphones workaround (which > relies on audioformat decoded from previous altsetting) > into two parts: prepare quirk flag analyzing previous > altsetting then use it with current altsetting. > > Signed-off-by: Ruslan Bilovol Could you try to split this patch to two parts: one is a simple refactoring to move the code to snd_usb_get_audioformat_uac12(), and another to add snd_usb_get_audioformat_uac3(). In this way, we can see a problem more clearly if it's in the refactoring part. thanks, Takashi