From: Takashi Iwai <tiwai@suse.de>
To: airlied@gmail.com
Cc: Dave Airlie <airlied@redhat.com>, alsa-devel@alsa-project.org
Subject: Re: [PATCH] alsa: hda_codec: fix number of devices query on hotplug
Date: Tue, 09 Jun 2015 07:36:12 +0200 [thread overview]
Message-ID: <s5hbngpbfzn.wl-tiwai@suse.de> (raw)
In-Reply-To: <1433821171-23519-1-git-send-email-airlied@gmail.com>
At Tue, 9 Jun 2015 13:39:31 +1000,
airlied@gmail.com wrote:
>
> From: Dave Airlie <airlied@redhat.com>
>
> The new regmap code seems to cache this, which isn't helpful
> for the hotplug dock situation where this gets updated.
>
> Use the uncached query for this.
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
Applied, thanks!
Takashi
> ---
> sound/pci/hda/hda_codec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
> index b49feff..b778221 100644
> --- a/sound/pci/hda/hda_codec.c
> +++ b/sound/pci/hda/hda_codec.c
> @@ -436,7 +436,7 @@ static unsigned int get_num_devices(struct hda_codec *codec, hda_nid_t nid)
> get_wcaps_type(wcaps) != AC_WID_PIN)
> return 0;
>
> - parm = snd_hda_param_read(codec, nid, AC_PAR_DEVLIST_LEN);
> + parm = snd_hdac_read_parm_uncached(&codec->core, nid, AC_PAR_DEVLIST_LEN);
> if (parm == -1 && codec->bus->rirb_error)
> parm = 0;
> return parm & AC_DEV_LIST_LEN_MASK;
> --
> 2.4.1
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
prev parent reply other threads:[~2015-06-09 5:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 3:39 [PATCH] alsa: hda_codec: fix number of devices query on hotplug airlied
2015-06-09 5:36 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hbngpbfzn.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=alsa-devel@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox