From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: alsa-devel@alsa-project.org, clemens@ladisch.de
Subject: Re: [PATCH] ALSA: firewire-lib: fix an unexpected byte sequence for micro sign
Date: Sat, 21 Feb 2015 08:56:50 +0100 [thread overview]
Message-ID: <s5hbnknpuil.wl-tiwai@suse.de> (raw)
In-Reply-To: <1424487017-24434-1-git-send-email-o-takashi@sakamocchi.jp>
At Sat, 21 Feb 2015 11:50:17 +0900,
Takashi Sakamoto wrote:
>
> The sign for microsecond (U+0085, MICRO SIGN) was encoded to '0x c2 b5'
> by UTF-8 character encoding scheme. But the byte sequence was converted
> to '0x c3 82 c2 b5' in a previous commit. As a result, the byte
> sequence cannot represent microsecond sign in UTF-8 or ASCII. This
> may confuse developers.
>
> This commit replaces the sign to string expression with 'microseconds'
> to purge superfluous troubles.
>
> Fixes: 5c697e5b46ef("ALSA: firewire-lib: remove rx_blocks_for_midi quirk")
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Applied, thanks.
Takashi
> ---
> sound/firewire/amdtp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/firewire/amdtp.c b/sound/firewire/amdtp.c
> index 0d58018..7b7b183 100644
> --- a/sound/firewire/amdtp.c
> +++ b/sound/firewire/amdtp.c
> @@ -33,7 +33,7 @@
> */
> #define MAX_MIDI_RX_BLOCKS 8
>
> -#define TRANSFER_DELAY_TICKS 0x2e00 /* 479.17 µs */
> +#define TRANSFER_DELAY_TICKS 0x2e00 /* 479.17 microseconds */
>
> /* isochronous header parameters */
> #define ISO_DATA_LENGTH_SHIFT 16
> --
> 2.1.0
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2015-02-21 7:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-21 2:50 [PATCH] ALSA: firewire-lib: fix an unexpected byte sequence for micro sign Takashi Sakamoto
2015-02-21 7:56 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hbnknpuil.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=o-takashi@sakamocchi.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox