From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 1/3] lx6464es: remove useles pci_set_drvdata(pdev, NULL) Date: Wed, 29 May 2013 12:17:17 +0200 Message-ID: References: <1369821802-2308-1-git-send-email-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id C3AED261ABC for ; Wed, 29 May 2013 12:16:38 +0200 (CEST) In-Reply-To: <1369821802-2308-1-git-send-email-andriy.shevchenko@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Andy Shevchenko Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Wed, 29 May 2013 13:03:20 +0300, Andy Shevchenko wrote: > > The driver core handles this. > > Signed-off-by: Andy Shevchenko Thanks, but I already queued a clean-up patch to remove the whole pci_set_drvdata() with NULL for all sound/* pci drivers. Takashi > --- > sound/pci/lx6464es/lx6464es.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sound/pci/lx6464es/lx6464es.c b/sound/pci/lx6464es/lx6464es.c > index 298bc9b..3230e57 100644 > --- a/sound/pci/lx6464es/lx6464es.c > +++ b/sound/pci/lx6464es/lx6464es.c > @@ -1139,7 +1139,6 @@ out_free: > static void snd_lx6464es_remove(struct pci_dev *pci) > { > snd_card_free(pci_get_drvdata(pci)); > - pci_set_drvdata(pci, NULL); > } > > > -- > 1.8.2.rc0.22.gb3600c3 >