From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: PATCH: Maxdata Favorit 100XS support
Date: Tue, 24 Feb 2009 12:35:02 +0100
Message-ID: <s5hbpss83vd.wl%tiwai@suse.de>
References: <20090201193039.GA24196@discworld.dascon.de>
	<s5htz797365.wl%tiwai@suse.de>
	<20090222175845.GA30047@discworld.dascon.de>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx1.suse.de (cantor.suse.de [195.135.220.2])
	by alsa0.perex.cz (Postfix) with ESMTP id E1F8924625
	for <alsa-devel@alsa-project.org>; Tue, 24 Feb 2009 12:35:02 +0100 (CET)
In-Reply-To: <20090222175845.GA30047@discworld.dascon.de>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Michael Schwingen <michael@schwingen.org>
Cc: alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

At Sun, 22 Feb 2009 18:58:45 +0100,
Michael Schwingen wrote:
> 
> On Thu, Feb 05, 2009 at 08:28:50AM +0100, Takashi Iwai wrote:
> > The patch looks almost good but there are a few issues to fix.
> > 
> > First off, please use a unified diff (diff -u) for a patch.
> > Then, rebase your patch to the latest sound git tree[*] or 2.6.29-rc3 
> > at least.
> >    git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git
> > 
> > Some stuff in patch_realtek.c in the latest tree was changed to be
> > incompatible from 2.6.28.  For example,
> > 
> > > + 	[ALC260_FAVORIT100] = {
> > > + 		.mixers = { alc260_favorit100_mixer,
> > > + 			    alc260_capture_mixer },
> > 
> > The capture mixer is now created dynamically.  Usually you don't need
> > pass capture_mixer array here.
> > 
> > > + 		.init_verbs = { alc260_acer_init_verbs },
> > 
> > Don't you use alc260_favorit100_init_verbs?
> > 
> > 
> > Could you fix these and repost?
> 
> Here is the updated patch, against the git version - is the diff format OK
> now?

Yes, it was merged to sound tree.  Sorry, forgot to notify you.

Thanks!

Takashi