From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] Add framework for better audigy sound card capabilities selection. Date: Mon, 21 Mar 2005 20:47:43 +0100 Message-ID: References: <423B345F.3000901@hotmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa.alsa-project.org (ALSA's E-mail Delivery System) with ESMTP id 145EF272 for ; Mon, 21 Mar 2005 20:48:02 +0100 (MET) In-Reply-To: <423B345F.3000901@hotmail.com> Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: "buzzbuzz2@hotmail.com" Cc: ALSA development List-Id: alsa-devel@alsa-project.org Hi, the idea looks nice, but... At Fri, 18 Mar 2005 20:04:47 +0000, buzzbuzz2@hotmail.com wrote: > > Index: alsa-driver/alsa-kernel/pci/emu10k1/emu10k1_main.c > =================================================================== > RCS file: /cvsroot/alsa/alsa-kernel/pci/emu10k1/emu10k1_main.c,v > retrieving revision 1.44 > diff -u -r1.44 emu10k1_main.c > --- alsa-driver/alsa-kernel/pci/emu10k1/emu10k1_main.c 13 Mar 2005 12:17:08 -0000 1.44 > +++ alsa-driver/alsa-kernel/pci/emu10k1/emu10k1_main.c 18 Mar 2005 19:55:33 -0000 > @@ -611,6 +611,22 @@ > return snd_emu10k1_free(emu); > } > > +/* vendor, device, subsystem, emu10k1_chip, emu10k2_chip, ca0102_chip, ca0108_chip, ca0151_chip, spk71, spdif_bug, ac97_chip, ecard, name */ > + > +static emu_chip_details_t emu_chip_details[] = { > + { 0x1102, 0x0008, 0x10011102, 0, 1, 0, 1, 0, 1, 0, 0, 0, "Audigy 2 Value [SB0400]"} , > + { 0x1102, 0x0008, 0x00000000, 0, 1, 0, 1, 0, 0, 0, 0, 0, "Audigy 2 Value [Unknown]"} , > + { 0x1102, 0x0004, 0x20071102, 0, 1, 1, 0, 1, 1, 0, 1, 0, "Audigy 4 PRO [SB0380]"} , > + { 0x1102, 0x0004, 0x20021102, 0, 1, 1, 0, 1, 1, 0, 1, 0, "Audigy 2 ZS [2002]"} , > + { 0x1102, 0x0004, 0x20011102, 0, 1, 1, 0, 1, 1, 0, 1, 0, "Audigy 2 ZS [2001]"} , > + { 0x1102, 0x0004, 0x10071102, 0, 1, 1, 0, 1, 1, 1, 1, 0, "Audigy 2 [SB0240]"} , > + { 0x1102, 0x0004, 0x10051102, 0, 1, 1, 0, 1, 0, 0, 0, 0, "Audigy 2 EX [1005]"} , > + { 0x1102, 0x0004, 0x00000000, 0, 1, 1, 0, 0, 0, 1, 0, 0, "Audigy 1 or 2 [Unknown]"} , > + { 0x1102, 0x0002, 0x40011102, 1, 0, 0, 0, 0, 0, 0, 0, 1, "E-mu APS [4001]"} , > + { 0x1102, 0x0002, 0x00000000, 1, 0, 0, 0, 0, 0, 0, 1, 0, "SB Live [Unknown]"} , > + { 0x0000, 0x0000, 0x00000000, 0, 0, 0, 0, 0, 0, 0, 0, 0, "Unknown"} , > +}; Can you rewrite in C99-init style, such as { .vendor = 0x1102, .device = 0x0004, .subsystem = 0x10051102, .emu10k2_chip = 1, ... }, ?? Takashi ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click