From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E44ACC4338F for ; Sat, 14 Aug 2021 06:42:46 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CFBF61028 for ; Sat, 14 Aug 2021 06:42:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0CFBF61028 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6AE6717AC; Sat, 14 Aug 2021 08:41:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6AE6717AC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1628923364; bh=BoyF/hxJciB3sCgRLpGEfxrcMXbyX0mLYKQ4v1i1EHY=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=OURI9gk6CIS1gVTloRvrQ7i24guKBXqM7Uy3tQUVAXTDzoKOvp1+TQH2N9ExQWn/M /BwsGN3VnA4C82vPNM5hZ24W8mH3RVyWXVamhIQYjFPKxeeH/hvWRtGQpQ/k9NvjFU o8+7XmPtQwrwSElBK7Y/ym7a9z1V5ct6VcwFPBok= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B20EDF80245; Sat, 14 Aug 2021 08:41:53 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 97E87F8025D; Sat, 14 Aug 2021 08:41:51 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 45EB4F80127 for ; Sat, 14 Aug 2021 08:41:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 45EB4F80127 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="LnX+PgqV"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="r0tiQSB/" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id B20AB1FD7A; Sat, 14 Aug 2021 06:41:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1628923300; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bY9UicE6suD1hc9Vf3ljsJVirNPAPxuBei1t88BMrLw=; b=LnX+PgqVW1Fpkwu+mHxfNA4GGhekKyUdjUhZMh5Cljnf1lM504am/QzskZHSdAHr59rVPS rLhyF1DuhR5K/3KvQWS728y6p/sm8p02nu5k8tbCStgowHb6Ql+fUEbqPbUxUBRGsH3f1l y3ivi/65KPnAD0p3SKOnPnouie4WGeU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1628923300; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bY9UicE6suD1hc9Vf3ljsJVirNPAPxuBei1t88BMrLw=; b=r0tiQSB/ZjjwkaS9DfmzvpD0bFpOGxAosr4CLAyQmZpMdItcADSgM4cPVgn6u/wMevpZc3 TjrP+fqhU0GX5bDg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 98B03A3B85; Sat, 14 Aug 2021 06:41:40 +0000 (UTC) Date: Sat, 14 Aug 2021 08:41:40 +0200 Message-ID: From: Takashi Iwai To: Vitaly Rodionov Subject: Re: [PATCH 2/2] ALSA: hda/cs8409: Prevent pops and clicks during reboot In-Reply-To: References: <20210812183433.6330-1-vitalyr@opensource.cirrus.com> <20210812183433.6330-2-vitalyr@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, Stefan Binding , Takashi Iwai , linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 13 Aug 2021 08:10:47 +0200, Takashi Iwai wrote: > > On Thu, 12 Aug 2021 20:34:33 +0200, > Vitaly Rodionov wrote: > > > > From: Stefan Binding > > > > During reboot, when the CS42L42 powers down, pops and clicks > > may occur due to the codec not being shutdown gracefully. > > This can be fixed by going through the suspend sequence, > > which shuts down the codec cleanly inside the reboot_notify > > hook, which is called on reboot. > > > > Signed-off-by: Stefan Binding > > Signed-off-by: Vitaly Rodionov > > I hold this one for now, as there is a fix series that deprecates the > reboot_notify callback of HD-audio by forcibly doing runtime-suspend > at shutdown. Please check the three patches in > https://bugzilla.kernel.org/show_bug.cgi?id=214045 > > I'm going to submit those soon in anyway. The removal of reboot_notifier landed in my for-next branch now. Please rebase and adapt the changes appropriately. In short, the runtime suspend is applied at the shutdown, so the workaround is needed only for suspend. thanks, Takashi