From: Takashi Iwai <tiwai@suse.de>
To: Fly Pig <flyingecar@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
alsa-devel@alsa-project.org
Subject: Re: [alsa-devel] [PATCH] ALSA: usb-audio: Add Gustard U16/X26 device family to quirks for native DSD support
Date: Wed, 23 Oct 2019 07:04:38 +0200 [thread overview]
Message-ID: <s5hd0eocas9.wl-tiwai@suse.de> (raw)
In-Reply-To: <CA+9XP1jeMVuzj0gz_-H6zV=cmjWQwvBLi08AED1KBie+kugmcg@mail.gmail.com>
On Wed, 23 Oct 2019 06:05:08 +0200,
Fly Pig wrote:
>
> Hi There
>
> This patch add native DSD support for Gustard U16/X26 USB Interface. Tested on
> my unit, working properly. Hence submit the patch.
>
> Cheers.
>
> Thank you very much.
>
> Pig
The upstream code changed the DSD detection recently, so your patch
doesn't apply. In short, check whether you get fp->dsd_raw set. If
yes, we can apply the vendor check instead of vendor:device pair
check.
Please resubmit the patch with the correction, and don't forget to add
your sign-off line (see Documentation/process/submitting-patches.rst).
It's a legal requirement for taking the patch to upstream.
thanks,
Takashi
>
> --- a/sound/usb/quirks.c 2019-09-22 21:28:09.757897000 +0000
> +++ b/sound/usb/quirks.c 2019-09-22 21:33:36.892274800 +0000
> @@ -1369,6 +1369,7 @@
> case USB_ID(0x22d9, 0x0461): /* OPPO UDP-205 */
> case USB_ID(0x2522, 0x0012): /* LH Labs VI DAC Infinity */
> case USB_ID(0x2772, 0x0230): /* Pro-Ject Pre Box S2 Digital */
> + case USB_ID(0x292b, 0xc4b3): /* Gustard U16 */
> if (fp->altsetting == 2)
> return SNDRV_PCM_FMTBIT_DSD_U32_BE;
> break;
>
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-10-23 5:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 4:05 [alsa-devel] [PATCH] ALSA: usb-audio: Add Gustard U16/X26 device family to quirks for native DSD support Fly Pig
2019-10-23 5:04 ` Takashi Iwai [this message]
2019-10-24 2:47 ` Fly Pig
2019-10-24 10:32 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hd0eocas9.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=flyingecar@gmail.com \
--cc=gregkh@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox