From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ALSA: sparc: Mark expected switch fall-throughs Date: Tue, 30 Jul 2019 09:39:02 +0200 Message-ID: References: <20190730014944.GA31900@embeddedor> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20190730014944.GA31900@embeddedor> Sender: linux-kernel-owner@vger.kernel.org To: " Gustavo A. R. Silva " Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, Kees Cook , linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Tue, 30 Jul 2019 03:49:44 +0200, Gustavo A. R. Silva wrote: > > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warnings (Building: sparc64): > > sound/sparc/dbri.c: In function ‘reverse_bytes’: > sound/sparc/dbri.c:582:5: warning: this statement may fall through [-Wimplicit-fallthrough=] > b = ((b & 0xffff0000) >> 16) | ((b & 0x0000ffff) << 16); > ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > sound/sparc/dbri.c:583:2: note: here > case 16: > ^~~~ > sound/sparc/dbri.c:584:5: warning: this statement may fall through [-Wimplicit-fallthrough=] > b = ((b & 0xff00ff00) >> 8) | ((b & 0x00ff00ff) << 8); > ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > sound/sparc/dbri.c:585:2: note: here > case 8: > ^~~~ > sound/sparc/dbri.c:586:5: warning: this statement may fall through [-Wimplicit-fallthrough=] > b = ((b & 0xf0f0f0f0) >> 4) | ((b & 0x0f0f0f0f) << 4); > ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > sound/sparc/dbri.c:587:2: note: here > case 4: > ^~~~ > sound/sparc/dbri.c:588:5: warning: this statement may fall through [-Wimplicit-fallthrough=] > b = ((b & 0xcccccccc) >> 2) | ((b & 0x33333333) << 2); > ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > sound/sparc/dbri.c:589:2: note: here > case 2: > ^~~~ > > Signed-off-by: Gustavo A. R. Silva Applied, thanks. Takashi