From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH - AAF PCM plugin 1/7] aaf: Introduce plugin
	skeleton
Date: Wed, 10 Oct 2018 12:27:35 +0200
Message-ID: <s5hd0sixfjc.wl-tiwai@suse.de>
References: <20181003234547.16839-1-andre.guedes@intel.com>
 <20181003234547.16839-2-andre.guedes@intel.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx1.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 4AAE12678AB
 for <alsa-devel@alsa-project.org>; Wed, 10 Oct 2018 12:27:36 +0200 (CEST)
In-Reply-To: <20181003234547.16839-2-andre.guedes@intel.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Andre Guedes <andre.guedes@intel.com>
Cc: alsa-devel@alsa-project.org, liam.r.girdwood@intel.com
List-Id: alsa-devel@alsa-project.org

On Thu, 04 Oct 2018 01:45:41 +0200,
Andre Guedes wrote:
> 
> +static int aaf_close(snd_pcm_ioplug_t *io)
> +{
> +	snd_pcm_aaf_t *aaf = io->private_data;
> +
> +	if (!aaf)
> +		return -EBADFD;
> +
> +	free(aaf);
> +	aaf = NULL;

This makes no sense.
The function can be simplified to

static int aaf_close(snd_pcm_ioplug_t *io)
{
	free(io->private_data);
	return 0;
}


thanks,

Takashi