From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: ALC298 headset mode support
Date: Tue, 12 May 2015 13:16:55 +0200
Message-ID: <s5hd226gi54.wl-tiwai@suse.de>
References: <6FAB7C47BCF00940BB0999A99BE3547A17A10470@RTITMBSV09.realtek.com.tw>
 <s5hk2wfgumq.wl-tiwai@suse.de>
 <6FAB7C47BCF00940BB0999A99BE3547A17A105CC@RTITMBSV09.realtek.com.tw>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id DA3782606B8
 for <alsa-devel@alsa-project.org>; Tue, 12 May 2015 13:16:57 +0200 (CEST)
In-Reply-To: <6FAB7C47BCF00940BB0999A99BE3547A17A105CC@RTITMBSV09.realtek.com.tw>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Kailang <kailang@realtek.com>
Cc: " (alsa-devel@alsa-project.org)" <alsa-devel@alsa-project.org>
List-Id: alsa-devel@alsa-project.org

At Tue, 12 May 2015 09:19:56 +0000,
Kailang wrote:
> 
> Hi Takashi, 
> 
> New patch attached.
> ALC298 hidden register was very similar to ALC286/ALC288.
> Many Thanks. ^^
> 
> BR,
> Kailang

OK, applied now.

thanks,

Takashi

> 
> > -----Original Message-----
> > From: Takashi Iwai [mailto:tiwai@suse.de] 
> > Sent: Monday, May 11, 2015 8:35 PM
> > To: Kailang
> > Cc: (alsa-devel@alsa-project.org)
> > Subject: Re: ALC298 headset mode support
> > 
> > At Mon, 11 May 2015 08:30:28 +0000,
> > Kailang wrote:
> > > 
> > > Hi Takashi,
> > >  
> > > I finished the alc298 headset mode supported.
> > > But it only tested via our develop system.
> > ....
> > > @@ -3801,6 +3804,8 @@ static void 
> > alc_headset_mode_ctia(struct hda_codec *codec)
> > > 	case 0x10ec0283:
> > > 		alc_process_coef_fw(codec, coef0233);
> > >  		break;
> > > +	case 0x10ec0298:
> > > +		alc_update_coef_idx(codec, 0x8e, 0x0070, 0x0020);
> > > 	case 0x10ec0286:
> > 
> > I suppose you didn't forget break in the above, right?
> Yes.
> 
> > If so, add a comment like /* fallthrough */ to indicate that 
> > it's the intentional code.  Ditto for other similar lines.
> > 
> > 
> > thanks,
> > 
> > Takashi
> > 
> > ------Please consider the environment before printing this e-mail.
> > 
> [2 0001-alc298-headset-mode.patch <application/octet-stream (base64)>]
>