From: Takashi Iwai <tiwai@suse.de>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: perex@perex.cz, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 1/6] sound: lx_core: Remove unused defines
Date: Fri, 18 Apr 2014 10:01:22 +0200 [thread overview]
Message-ID: <s5hd2gfukvh.wl%tiwai@suse.de> (raw)
In-Reply-To: <1397728281-26050-1-git-send-email-maxime.ripard@free-electrons.com>
At Thu, 17 Apr 2014 11:51:16 +0200,
Maxime Ripard wrote:
>
> Commit f9367f3fbe3c ("ALSA: lx6464es: Remove unused
> function in pci/lx6464es/lx_core.c") removed the
> lx_dsp_es_check_pipeline function that was the only user
> of these defines.
>
> Since they're useless now, simply remove them.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks, applied all patches now.
But, at the next time, please put my correct address to Cc.
Also, for ALSA stuff (except for ASoC), we usually use "ALSA:"
prefix.
Takashi
> ---
> sound/pci/lx6464es/lx_core.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/sound/pci/lx6464es/lx_core.c b/sound/pci/lx6464es/lx_core.c
> index 2d8e95e9fbe5..6a1d90a308ea 100644
> --- a/sound/pci/lx6464es/lx_core.c
> +++ b/sound/pci/lx6464es/lx_core.c
> @@ -429,11 +429,6 @@ int lx_dsp_read_async_events(struct lx6464es *chip, u32 *data)
> return ret;
> }
>
> -#define CSES_TIMEOUT 100 /* microseconds */
> -#define CSES_CE 0x0001
> -#define CSES_BROADCAST 0x0002
> -#define CSES_UPDATE_LDSV 0x0004
> -
> #define PIPE_INFO_TO_CMD(capture, pipe) \
> ((u32)((u32)(pipe) | ((capture) ? ID_IS_CAPTURE : 0L)) << ID_OFFSET)
>
> --
> 1.9.1
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
next prev parent reply other threads:[~2014-04-18 8:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 9:51 [PATCH 1/6] sound: lx_core: Remove unused defines Maxime Ripard
2014-04-17 9:51 ` [PATCH 2/6] sound: lx_core: Switch to using BIT macro Maxime Ripard
2014-04-17 9:51 ` [PATCH 3/6] sound: lx_core: Fix dev_dbg typo Maxime Ripard
2014-04-17 9:51 ` [PATCH 4/6] sound: lx_core: Remove dead code Maxime Ripard
2014-04-17 9:51 ` [PATCH 5/6] sound: lx_core: Remove useless #if 0 .. #endif Maxime Ripard
2014-04-17 9:51 ` [PATCH 6/6] sound: lx_core: Translate comments from french to english Maxime Ripard
2014-04-18 8:01 ` Takashi Iwai [this message]
2014-04-18 9:45 ` [PATCH 1/6] sound: lx_core: Remove unused defines Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hd2gfukvh.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox