From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ALSA: HDA: Pinfix quirk for HP Z200 Workstation Date: Thu, 23 Jun 2011 09:28:35 +0200 Message-ID: References: <4E02510B.5090404@canonical.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 92FEE103AA7 for ; Thu, 23 Jun 2011 09:28:35 +0200 (CEST) In-Reply-To: <4E02510B.5090404@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: David Henningsson Cc: ALSA Development Mailing List List-Id: alsa-devel@alsa-project.org At Wed, 22 Jun 2011 22:31:07 +0200, David Henningsson wrote: > > BIOS lists the internal speaker as an internal line-out. Change to > internal speaker + model=auto for better auto-mute capabilities. > > Relevant alsa-info is here: > https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/754964/+attachment/2002204/+files/alsa-info.txt Thanks, applied now. 3.0 should work even without this patch since line-out can be auto-muted now, but it's still more correct to show the speaker as speaker (e.g. the right mixer name). So, it's still good to have this kind of fix. Takashi > > -- > David Henningsson, Canonical Ltd. > http://launchpad.net/~diwic > [2 0001-ALSA-HDA-Pinfix-quirk-for-HP-Z200-Workstation.patch ] > >From 86033a5031f8dffdb72bbdfac2286063ad5cd72d Mon Sep 17 00:00:00 2001 > From: David Henningsson > Date: Wed, 22 Jun 2011 09:58:37 +0200 > Subject: [PATCH] ALSA: HDA: Pinfix quirk for HP Z200 Workstation > > BIOS lists the internal speaker as an internal line-out. Change to > internal speaker + model=auto for better auto-mute capabilities. > > BugLink: http://bugs.launchpad.net/bugs/754964 > Reported-by: Marc Legris > Signed-off-by: David Henningsson > --- > sound/pci/hda/patch_realtek.c | 11 +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 4adf9e2..fe56b2b 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -12600,6 +12600,7 @@ static const struct hda_verb alc262_toshiba_rx1_unsol_verbs[] = { > */ > enum { > PINFIX_FSC_H270, > + PINFIX_HP_Z200, > }; > > static const struct alc_fixup alc262_fixups[] = { > @@ -12612,9 +12613,17 @@ static const struct alc_fixup alc262_fixups[] = { > { } > } > }, > + [PINFIX_HP_Z200] = { > + .type = ALC_FIXUP_PINS, > + .v.pins = (const struct alc_pincfg[]) { > + { 0x16, 0x99130120 }, /* internal speaker */ > + { } > + } > + }, > }; > > static const struct snd_pci_quirk alc262_fixup_tbl[] = { > + SND_PCI_QUIRK(0x103c, 0x170b, "HP Z200", PINFIX_HP_Z200), > SND_PCI_QUIRK(0x1734, 0x1147, "FSC Celsius H270", PINFIX_FSC_H270), > {} > }; > @@ -12731,6 +12740,8 @@ static const struct snd_pci_quirk alc262_cfg_tbl[] = { > ALC262_HP_BPC), > SND_PCI_QUIRK_MASK(0x103c, 0xff00, 0x1500, "HP z series", > ALC262_HP_BPC), > + SND_PCI_QUIRK(0x103c, 0x170b, "HP Z200", > + ALC262_AUTO), > SND_PCI_QUIRK_MASK(0x103c, 0xff00, 0x1700, "HP xw series", > ALC262_HP_BPC), > SND_PCI_QUIRK(0x103c, 0x2800, "HP D7000", ALC262_HP_BPC_D7000_WL), > -- > 1.7.4.1 >