Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: 596478@bugs.debian.org, alsa-devel@alsa-project.org,
	Carmen Cru <carmen.cru@belgacom.net>
Subject: Re: [PATCH] ALSA: emux: Add trivial compat ioctl handler
Date: Tue, 14 Sep 2010 16:20:30 +0200	[thread overview]
Message-ID: <s5hd3sg5rv5.wl%tiwai@suse.de> (raw)
In-Reply-To: <1284255707.5323.638.camel@localhost>

At Sun, 12 Sep 2010 02:41:47 +0100,
Ben Hutchings wrote:
> 
> Reported-by: Carmen Cru <carmen.cru@belgacom.net>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> This is compile-tested only.

Thanks, applied now.


Takashi

> 
> Ben.
> 
>  sound/synth/emux/emux_hwdep.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/synth/emux/emux_hwdep.c b/sound/synth/emux/emux_hwdep.c
> index ff0b2a8..5ae1eae 100644
> --- a/sound/synth/emux/emux_hwdep.c
> +++ b/sound/synth/emux/emux_hwdep.c
> @@ -128,6 +128,9 @@ snd_emux_init_hwdep(struct snd_emux *emu)
>  	strcpy(hw->name, SNDRV_EMUX_HWDEP_NAME);
>  	hw->iface = SNDRV_HWDEP_IFACE_EMUX_WAVETABLE;
>  	hw->ops.ioctl = snd_emux_hwdep_ioctl;
> +	/* The ioctl parameter types are compatible between 32- and
> +	 * 64-bit architectures, so use the same function. */
> +	hw->ops.ioctl_compat = snd_emux_hwdep_ioctl;
>  	hw->exclusive = 1;
>  	hw->private_data = emu;
>  	if ((err = snd_card_register(emu->card)) < 0)
> -- 
> 1.7.1
> 
> 

      reply	other threads:[~2010-09-14 14:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-12  1:41 Bug#596478: [PATCH] ALSA: emux: Add trivial compat ioctl handler Ben Hutchings
2010-09-14 14:20 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hd3sg5rv5.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=596478@bugs.debian.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=ben@decadent.org.uk \
    --cc=carmen.cru@belgacom.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox