From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [RFC] [Patch 2/2] Add virtual master to HD-audio Date: Sun, 13 Jan 2008 12:04:47 +0100 Message-ID: References: <20080112202122.GA29942@caradoc.them.org> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 9F9022495A for ; Sun, 13 Jan 2008 12:04:47 +0100 (CET) In-Reply-To: <20080112202122.GA29942@caradoc.them.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Daniel Jacobowitz Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Sat, 12 Jan 2008 15:21:22 -0500, Daniel Jacobowitz wrote: > > On Thu, Dec 20, 2007 at 04:46:35PM +0100, Takashi Iwai wrote: > > static struct snd_kcontrol_new alc880_lg_mixer[] = { > > /* FIXME: it's not really "master" but front channels */ > > - HDA_CODEC_VOLUME("Master Playback Volume", 0x0f, 0x0, HDA_OUTPUT), > > - HDA_BIND_MUTE("Master Playback Switch", 0x0f, 2, HDA_INPUT), > > + HDA_CODEC_VOLUME("Front Playback Volume", 0x0f, 0x0, HDA_OUTPUT), > > + HDA_BIND_MUTE("Front Playback Switch", 0x0f, 2, HDA_INPUT), > > You've just fixed that FIXME :-) Yeah, fixed FIXME now ;) Takashi