alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: alsa-devel@alsa-project.org
Subject: Re: [PATCH alsa-utils] alsactl: Make sure the kernel driver loaded before alsa-restore.service
Date: Sat, 28 Nov 2020 22:33:49 +0100	[thread overview]
Message-ID: <s5heekdgo8y.wl-tiwai@suse.de> (raw)
In-Reply-To: <20201128203101.7333-1-tiwai@suse.de>

On Sat, 28 Nov 2020 21:31:01 +0100,
Takashi Iwai wrote:
> 
> alsa-restore.service requires the sound devices having been set up
> beforehand.  However, systemd tends to start this service too early
> before the driver setup, which leads to the unsuccessful state
> restore.
> 
> For assuring the kernel driver setup before this service, add the
> dependency on sound.target.
> 
> BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1179363
> Signed-off-by: Takashi Iwai <tiwai@suse.de>

Scratch this.  There is already certain dependencies between this
service and sound.target.  It needs more investigation why it doesn't
work as expected.


Takashi

> ---
>  alsactl/alsa-restore.service.in | 2 ++

>  1 file changed, 2 insertions(+)
> 
> diff --git a/alsactl/alsa-restore.service.in b/alsactl/alsa-restore.service.in
> index a84c2e842444..104b97a6ef68 100644
> --- a/alsactl/alsa-restore.service.in
> +++ b/alsactl/alsa-restore.service.in
> @@ -8,6 +8,8 @@ Description=Save/Restore Sound Card State
>  ConditionPathExists=!@daemonswitch@
>  ConditionPathExistsGlob=/dev/snd/control*
>  ConditionPathExists=@asoundrcfile@
> +Requires=sound.target
> +After=sound.target
>  
>  [Service]
>  Type=oneshot
> -- 
> 2.26.2
> 

      reply	other threads:[~2020-11-28 21:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-28 20:31 [PATCH alsa-utils] alsactl: Make sure the kernel driver loaded before alsa-restore.service Takashi Iwai
2020-11-28 21:33 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5heekdgo8y.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).