From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AA98C63777 for ; Sat, 28 Nov 2020 21:35:00 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 165E2221FF for ; Sat, 28 Nov 2020 21:34:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="haK/BPuB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 165E2221FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A16341856; Sat, 28 Nov 2020 22:34:05 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A16341856 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1606599295; bh=kXJDFvOlJ+lhah4tbpIgpHY5F5zAm366xsjK945rzAk=; h=Date:From:To:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=haK/BPuBeOl+3u/bgjTjcZvBfWNM7klRJjd6J4ZFqDbQj4yGtoHQ+2aPM3a8fmibG l3Ce+BnLH/yHkEKw2gei+R2h95WK3u52kZzG5MU5gZ2JC71BV+nM4/IcyY6aemNLJ6 gfbvghfan+kNj7b77yGzTw5xaUioY5rau7MXJfRs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2C826F80165; Sat, 28 Nov 2020 22:34:05 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1647FF80166; Sat, 28 Nov 2020 22:33:59 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id EFC67F800EA for ; Sat, 28 Nov 2020 22:33:49 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz EFC67F800EA X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3A721AC23 for ; Sat, 28 Nov 2020 21:33:49 +0000 (UTC) Date: Sat, 28 Nov 2020 22:33:49 +0100 Message-ID: From: Takashi Iwai To: alsa-devel@alsa-project.org Subject: Re: [PATCH alsa-utils] alsactl: Make sure the kernel driver loaded before alsa-restore.service In-Reply-To: <20201128203101.7333-1-tiwai@suse.de> References: <20201128203101.7333-1-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, 28 Nov 2020 21:31:01 +0100, Takashi Iwai wrote: > > alsa-restore.service requires the sound devices having been set up > beforehand. However, systemd tends to start this service too early > before the driver setup, which leads to the unsuccessful state > restore. > > For assuring the kernel driver setup before this service, add the > dependency on sound.target. > > BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1179363 > Signed-off-by: Takashi Iwai Scratch this. There is already certain dependencies between this service and sound.target. It needs more investigation why it doesn't work as expected. Takashi > --- > alsactl/alsa-restore.service.in | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/alsactl/alsa-restore.service.in b/alsactl/alsa-restore.service.in > index a84c2e842444..104b97a6ef68 100644 > --- a/alsactl/alsa-restore.service.in > +++ b/alsactl/alsa-restore.service.in > @@ -8,6 +8,8 @@ Description=Save/Restore Sound Card State > ConditionPathExists=!@daemonswitch@ > ConditionPathExistsGlob=/dev/snd/control* > ConditionPathExists=@asoundrcfile@ > +Requires=sound.target > +After=sound.target > > [Service] > Type=oneshot > -- > 2.26.2 >