From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15D36C433DF for ; Thu, 11 Jun 2020 12:31:13 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8BB922072F for ; Thu, 11 Jun 2020 12:31:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="WJJxZNf+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8BB922072F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0BB681684; Thu, 11 Jun 2020 14:30:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0BB681684 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1591878671; bh=maRT1G0zjiTuUWJAQMFWIImZVOU2i5em7Eb1ivzgBt4=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=WJJxZNf+Spo0bG9k3VsNNY8hX56pdi24FTp9FARlj+w5yKTMLpgJQ3UtpPiGgnwBK NxNdUi2fQcxBbAyiVwu4KorQjlQKylLpZlaALGL207hwXF92jNvT10amAevB9g/Njk J4bYcdLUlPjvPegxa7YBaZxLu/SHgvwo1g6KVl9Y= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 917FDF800CC; Thu, 11 Jun 2020 14:30:20 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 552F8F80290; Thu, 11 Jun 2020 14:30:19 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E23E8F800CC for ; Thu, 11 Jun 2020 14:30:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E23E8F800CC X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id E26F6AE91; Thu, 11 Jun 2020 12:30:19 +0000 (UTC) Date: Thu, 11 Jun 2020 14:30:15 +0200 Message-ID: From: Takashi Iwai To: Laurence Tratt Subject: Re: Clock sync problem? In-Reply-To: <20200610162912.ltwyjc4tpxsst3rf@overdrive.tratt.net> References: <20200607133959.kmljpqdwefuio3mk@overdrive.tratt.net> <14f91307-c121-a9f8-4045-1319ee0ca49e@bollie.de> <20200610074409.aknnhrzzu3ulfa4e@overdrive.tratt.net> <325c117faed8514693f0f82d00961efa09fc1b00.camel@tsoy.me> <20200610162912.ltwyjc4tpxsst3rf@overdrive.tratt.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: Alexander Tsoy , Thomas Ebeling , alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 10 Jun 2020 18:29:12 +0200, Laurence Tratt wrote: > > On Wed, Jun 10, 2020 at 04:49:14PM +0300, Alexander Tsoy wrote: > > Hello Alexander, > > > Thanks! So SSL 2+ is indeed currently needs implicit feedback quirk. > > The question is why it didn't help in your case. > > It didn't work because I was an idiot and used the wrong manufacturer ID. > When I fixed that typo, the drift disappeared. Patch attached! Great, care to submit the patch in a proper format? > [It's reasonable to assume that this will also work for the SSL2, but I > don't know its ID: it might use the same ID as the SSL2+ or perhaps its > 0x0001. Unfortunately I suspect we'll have to wait until one is observed in > the wild to know.] Yes, the addition can be done easily at any time, so let's take the known working one at first. thanks, Takashi > > > Laurie > > > diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c > index 8a05dcb134..abf726c49f 100644 > --- a/sound/usb/pcm.c > +++ b/sound/usb/pcm.c > @@ -367,6 +367,7 @@ static int set_sync_ep_implicit_fb_quirk(struct snd_usb_substream *subs, > ifnum = 0; > goto add_sync_ep_from_ifnum; > case USB_ID(0x07fd, 0x0008): /* MOTU M Series */ > + case USB_ID(0x31e9, 0x0002): /* Solid State Logic SSL2+ */ > ep = 0x81; > ifnum = 2; > goto add_sync_ep_from_ifnum; >