From: Takashi Iwai <tiwai@suse.de>
To: Daniel Baluta <daniel.baluta@nxp.com>
Cc: alsa-devel@alsa-project.org, shengjiu.wang@nxp.com,
o-takashi@sakamocchi.jp, broonie@kernel.org,
viorel.suman@nxp.com, mihai.serban@nxp.com
Subject: Re: [PATCH v2] aplay: Introduce and use xwrite helper
Date: Mon, 10 Apr 2017 09:12:25 +0200 [thread overview]
Message-ID: <s5hefx068iu.wl-tiwai@suse.de> (raw)
In-Reply-To: <1491807873-29557-1-git-send-email-daniel.baluta@nxp.com>
On Mon, 10 Apr 2017 09:04:33 +0200,
Daniel Baluta wrote:
>
> Write can return less then requested bytes, but we treat this as
> an error thus ending up with confusing error messages.
>
> Fix this by introducing xwrite helper, which makes sure all bytes
> are written or an error is returned.
>
> With this patch an usecase where disk is filled by recording will
> print:
> $ /mnt/msc/audio.wav: No space left on device
>
> instead of random messages like:
>
> $/mnt/msc/audio.wav: No such file or directory
>
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> ---
> Changes since v1:
> * return the correct number of bytes
Applied, thanks.
Takashi
prev parent reply other threads:[~2017-04-10 7:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 7:04 [PATCH v2] aplay: Introduce and use xwrite helper Daniel Baluta
2017-04-10 7:12 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hefx068iu.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=mihai.serban@nxp.com \
--cc=o-takashi@sakamocchi.jp \
--cc=shengjiu.wang@nxp.com \
--cc=viorel.suman@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox