From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] ALSA: x86: hdmi: select CONFIG_SND_PCM
Date: Tue, 21 Feb 2017 23:40:22 +0100
Message-ID: <s5hefyrnp61.wl-tiwai@suse.de>
References: <20170221220255.242105-1-arnd@arndb.de>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 50822266AA9
 for <alsa-devel@alsa-project.org>; Tue, 21 Feb 2017 23:40:23 +0100 (CET)
In-Reply-To: <20170221220255.242105-1-arnd@arndb.de>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Arnd Bergmann <arnd@arndb.de>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, alsa-devel@alsa-project.org, Jerome Anand <jerome.anand@intel.com>, linux-kernel@vger.kernel.org
List-Id: alsa-devel@alsa-project.org

On Tue, 21 Feb 2017 23:02:37 +0100,
Arnd Bergmann wrote:
> 
> The newly added driver uses the PCM helpers and fails to link if they are disabled:
> 
> sound/built-in.o: In function `hdmi_lpe_audio_runtime_suspend':
> intel_hdmi_audio.c:(.text+0x15906): undefined reference to `snd_pcm_suspend'
> sound/built-in.o: In function `had_pcm_hw_params':
> intel_hdmi_audio.c:(.text+0x15ac7): undefined reference to `snd_pcm_lib_malloc_pages'
> sound/built-in.o: In function `had_pcm_open':
> intel_hdmi_audio.c:(.text+0x15d49): undefined reference to `snd_pcm_hw_constraint_integer'
> 
> This uses a Kconfig 'select' statement to make sure they are enabled.
> 
> Fixes: 5dab11d89777 ("ALSA: x86: hdmi: Add audio support for BYT and CHT")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks, applied.


Takashi