From: Takashi Iwai <tiwai@suse.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, patches.audio@intel.com,
lgirdwood@gmail.com, Ramesh Babu <ramesh.babu@intel.com>,
Vinod Koul <vinod.koul@intel.com>,
broonie@kernel.org,
"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Subject: Re: [PATCH 1/7] ALSA: core: let low-level driver or userspace disable rewinds
Date: Fri, 21 Oct 2016 17:57:24 +0200 [thread overview]
Message-ID: <s5heg39g0ez.wl-tiwai@suse.de> (raw)
In-Reply-To: <1cfa9993-cdfb-9ef5-907b-845633173965@linux.intel.com>
Hi,
sorry for the late response. I've been slowly catching up the pending
stuff...
On Mon, 03 Oct 2016 16:39:41 +0200,
Pierre-Louis Bossart wrote:
>
>
> >>> @@ -2438,6 +2440,9 @@ static snd_pcm_sframes_t snd_pcm_playback_rewind(struct snd_pcm_substream *subst
> >>> if (frames == 0)
> >>> return 0;
> >>>
> >>> + if (runtime->no_rewinds)
> >>> + return 0;
> >>
> >> Better to return an error instead?
> >
> > As the number of frames rewinded is zero, it looks appropriate. Any reason
> > why returning an error code would help?
Well, this is an operation that is not supposed to work. The
configuration declares that there shall be no rewind, right?
> The return type is also snd_sframes_t, not sure how a error code would
> be returned without additional changes.
snd_pcm_sframes_t is a signed type, and a negative value is taken as
an error by ioctl.
thanks,
Takashi
next prev parent reply other threads:[~2016-10-21 15:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 12:43 [PATCH 0/7] ALSA: Add rewinds disabled, delays, max_inflight_bytes Subhransu S. Prusty
2016-09-30 12:43 ` [PATCH 1/7] ALSA: core: let low-level driver or userspace disable rewinds Subhransu S. Prusty
2016-09-30 13:22 ` Takashi Iwai
2016-10-03 4:40 ` Subhransu S. Prusty
2016-10-03 14:39 ` Pierre-Louis Bossart
2016-10-21 15:57 ` Takashi Iwai [this message]
2016-09-30 12:43 ` [PATCH 2/7] ALSA: core: add .update_appl_ptr callback for pcm ops Subhransu S. Prusty
2016-09-30 13:24 ` Takashi Iwai
2016-09-30 17:20 ` Vinod Koul
2016-09-30 18:38 ` Takashi Iwai
2016-10-03 4:36 ` Vinod Koul
2016-10-03 14:49 ` Pierre-Louis Bossart
2016-09-30 12:43 ` [PATCH 3/7] ALSA: pcm: avoid mmap of control data if .update_appl_ptr is implemented Subhransu S. Prusty
2016-09-30 13:40 ` Takashi Iwai
2016-10-03 4:43 ` Subhransu S. Prusty
2016-09-30 12:43 ` [PATCH 4/7] ALSA: core: add report of max inflight bytes Subhransu S. Prusty
2016-09-30 13:44 ` Takashi Iwai
2016-09-30 12:43 ` [PATCH 5/7] ALSA: hda: add default value for max_inflight_bytes Subhransu S. Prusty
2016-10-03 8:48 ` Hardik Shah
2016-10-03 14:44 ` Pierre-Louis Bossart
2016-09-30 12:43 ` [PATCH 6/7] ALSA: usb: no_period_wake and max_inflight_bytes report Subhransu S. Prusty
2016-09-30 12:43 ` [PATCH 7/7] ALSA: usb: take startup delay into account Subhransu S. Prusty
2016-09-30 13:44 ` Takashi Iwai
2016-10-03 15:04 ` Pierre-Louis Bossart
2016-10-21 16:00 ` Takashi Iwai
2016-10-03 6:46 ` Takashi Sakamoto
2016-10-03 15:08 ` Pierre-Louis Bossart
2016-10-03 17:31 ` Takashi Sakamoto
2016-09-30 13:13 ` [PATCH 0/7] ALSA: Add rewinds disabled, delays, max_inflight_bytes Takashi Iwai
2016-10-03 4:28 ` Subhransu S. Prusty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5heg39g0ez.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=patches.audio@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ramesh.babu@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).