Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jesper Juhl <jj@chaosbits.net>
Cc: alsa-devel@alsa-project.org, trivial@kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 01/37] Remove unneeded version.h includes from sound/
Date: Fri, 24 Jun 2011 11:29:47 +0200	[thread overview]
Message-ID: <s5hei2jzies.wl%tiwai@suse.de> (raw)
In-Reply-To: <alpine.LNX.2.00.1106232353040.17688@swampdragon.chaosbits.net>

At Thu, 23 Jun 2011 23:54:40 +0200 (CEST),
Jesper Juhl wrote:
> 
> In the sound/ directory there are two files (flagged by 'make
> versioncheck'); sound/pci/asihpi/asihpi.c and
> sound/soc/codecs/wm8991.c that include linux/version.h although they
> don't need it. This patch removes the unneeded includes.
> 
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>

Thanks, applied to sound git tree now.


Takashi

> ---
>  sound/pci/asihpi/asihpi.c |    1 -
>  sound/soc/codecs/wm8991.c |    1 -
>  2 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/pci/asihpi/asihpi.c b/sound/pci/asihpi/asihpi.c
> index 2ca6f4f..e3569bd 100644
> --- a/sound/pci/asihpi/asihpi.c
> +++ b/sound/pci/asihpi/asihpi.c
> @@ -27,7 +27,6 @@
>  #include "hpioctl.h"
>  
>  #include <linux/pci.h>
> -#include <linux/version.h>
>  #include <linux/init.h>
>  #include <linux/jiffies.h>
>  #include <linux/slab.h>
> diff --git a/sound/soc/codecs/wm8991.c b/sound/soc/codecs/wm8991.c
> index 3c2ee1b..6af23d0 100644
> --- a/sound/soc/codecs/wm8991.c
> +++ b/sound/soc/codecs/wm8991.c
> @@ -13,7 +13,6 @@
>  
>  #include <linux/module.h>
>  #include <linux/moduleparam.h>
> -#include <linux/version.h>
>  #include <linux/kernel.h>
>  #include <linux/init.h>
>  #include <linux/delay.h>
> -- 
> 1.7.5.2
> 
> 
> -- 
> Jesper Juhl <jj@chaosbits.net>       http://www.chaosbits.net/
> Don't top-post http://www.catb.org/jargon/html/T/top-post.html
> Plain text mails only, please.
> 

      reply	other threads:[~2011-06-24  9:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <alpine.LNX.2.00.1106232344480.17688@swampdragon.chaosbits.net>
2011-06-23 21:54 ` [PATCH 01/37] Remove unneeded version.h includes from sound/ Jesper Juhl
2011-06-24  9:29   ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hei2jzies.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=jj@chaosbits.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox