From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ASoC: make ops a pointer in 'struct snd_soc_dai' Date: Mon, 02 Mar 2009 12:55:32 +0100 Message-ID: References: Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 01FC324451 for ; Mon, 2 Mar 2009 12:55:32 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Eric Miao Cc: alsa-devel@alsa-project.org, Mark Brown , Liam Girdwood List-Id: alsa-devel@alsa-project.org At Mon, 2 Mar 2009 11:25:46 +0800, Eric Miao wrote: > > Considering the fact that most cpu_dai or codec_dai are using a same > 'snd_soc_dai_ops' for several similar interfaces, 'ops' would be better > made a pointer instead, to make sharing easier and code a bit cleaner. > > The patch below is rather preliminary since the asoc tree is being > actively developed, and this touches almost every piece of code, > (and possibly many others in development need to be changed as > well). Building of all codecs are OK, yet to every SoC, I didn't test > that. > > Signed-off-by: Eric Miao Don't forget to update Documentation/sound/alsa/soc/*, too. (I don't mind who does it, though ;) thanks, Takashi