From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 1/2] sis7019: support the SiS 7019
	Audio	Accelerator
Date: Wed, 28 Nov 2007 10:56:01 +0100
Message-ID: <s5hejeaithq.wl%tiwai@suse.de>
References: <1196234344.7017.31.camel@obelisk.thedillows.org>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx1.suse.de (ns.suse.de [195.135.220.2])
	by alsa0.perex.cz (Postfix) with ESMTP id 25CE224B0A
	for <alsa-devel@alsa-project.org>; Wed, 28 Nov 2007 11:30:01 +0100 (CET)
In-Reply-To: <1196234344.7017.31.camel@obelisk.thedillows.org>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Dave Dillow <dave@thedillows.org>
Cc: alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

At Wed, 28 Nov 2007 02:19:03 -0500,
Dave Dillow wrote:
> +static int index[SNDRV_CARDS] = SNDRV_DEFAULT_IDX;	/* Index 0-MAX */
> +static char *id[SNDRV_CARDS] = SNDRV_DEFAULT_STR;	/* ID for this card */
> +static int enable[SNDRV_CARDS] = SNDRV_DEFAULT_ENABLE_PNP;	/* Enable this card */

Can there be multiple SIS7019 devices?  If there can only a single
device, let's avoid array.

> +module_param_array(index, int, NULL, 0444);
> +MODULE_PARM_DESC(index, "Index value for SiS7019 Audio Accelerator.");
> +module_param_array(id, charp, NULL, 0444);
> +MODULE_PARM_DESC(id, "ID string for SiS7019 Audio Accelerator.");
> +module_param_array(enable, bool, NULL, 0444);
> +MODULE_PARM_DESC(enable, "Enable SiS7019 Audio Accelerator.");

Ditto.

> +static struct snd_pcm_hardware sis_playback_hw_info = {
> +	.info = (SNDRV_PCM_INFO_MMAP |
> +		 SNDRV_PCM_INFO_MMAP_VALID |
> +		 SNDRV_PCM_INFO_INTERLEAVED |
> +		 SNDRV_PCM_INFO_BLOCK_TRANSFER |
> +		 SNDRV_PCM_INFO_SYNC_START |
> +		 SNDRV_PCM_INFO_RESUME),

SNDRV_PCM_INFO_SYNC_START seems invalid here.  It's not implemented in
the driver.

> +static void __sis_map_silence(struct sis7019 *sis)

Any reason to use __ prefix?


Thanks,

Takashi