Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Krzysztof Helt <krzysztof.h1@wp.pl>
Cc: alsa-devel@alsa-project.org, Rene Herman <rene.herman@gmail.com>
Subject: Re: [PATCH] ad1848_lib: replace common delay loop by function
Date: Wed, 05 Sep 2007 18:50:54 +0200	[thread overview]
Message-ID: <s5hejhd6opd.wl%tiwai@suse.de> (raw)
In-Reply-To: <20070905184225.5eaa6655.krzysztof.h1@wp.pl>

At Wed, 5 Sep 2007 18:42:25 +0200,
Krzysztof Helt wrote:
> 
> On Wed, 05 Sep 2007 15:02:53 +0200
> Takashi Iwai <tiwai@suse.de> wrote:
> 
> > At Wed, 05 Sep 2007 00:41:25 +0200,
> > Rene Herman wrote:
> > > 
> > > On 09/04/2007 11:53 PM, Krzysztof Helt wrote:
> > > 
> > > > +static void snd_ad1848_ready(struct snd_ad1848 *chip)
> > > 
> > > Same request for a name change -- "ready" sounds boolean to me...
> > 
> > Agreed.  Also, the error output of timeout can be better in
> > snd_ad1848_ready().
> > 
> 
> As to the error output. The moved error output want be able to
> display register and value to write (unless it will have parameters only for this).
> Also there is no error message in the snd_ad1848_dout().

I believe this must be just a laziness :)
But it's no big matter to argue.  So, I don't mind at all whether you
move or keep the check code there.


Takashi

  reply	other threads:[~2007-09-05 16:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-04 21:53 [PATCH] ad1848_lib: replace common delay loop by function Krzysztof Helt
2007-09-04 22:41 ` Rene Herman
2007-09-05 13:02   ` Takashi Iwai
2007-09-05 16:42     ` Krzysztof Helt
2007-09-05 16:50       ` Takashi Iwai [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-09-05 17:04 Krzysztof Helt
2007-09-05 19:06 ` Rene Herman
2007-09-06 13:14 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hejhd6opd.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=krzysztof.h1@wp.pl \
    --cc=rene.herman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox