From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] hda: add sigmatel dig mic support and refactor 9227 Date: Thu, 26 Oct 2006 13:02:30 +0200 Message-ID: References: <20061025202110.GA351@matthew-porters-computer.local> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx1.suse.de [195.135.220.2]) by alsa.jcu.cz (ALSA's E-mail Delivery System) with ESMTP id 548BC197 for ; Thu, 26 Oct 2006 13:02:45 +0200 (MEST) In-Reply-To: <20061025202110.GA351@matthew-porters-computer.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@lists.sourceforge.net Errors-To: alsa-devel-bounces@lists.sourceforge.net To: Matt Porter Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Wed, 25 Oct 2006 16:21:10 -0400, Matt Porter wrote: > @@ -41,10 +41,8 @@ > #define STAC_D945GTP3 1 > #define STAC_D945GTP5 2 > #define STAC_MACMINI 3 > -#define STAC_922X_MODELS 4 /* number of 922x models */ > #define STAC_D965_3ST 4 > #define STAC_D965_5ST 5 > -#define STAC_927X_MODELS 6 /* number of 922x models */ You cannot remove XXX_MODELS. The size of *_brd_tbl[] must be defined as the max number of models. Otherwise you might access to outside the array since the driver checks the value of *_brd_tbl[model]. Also, some lines you added exceed 80-columns rule. I know there are still more lines over 80 chars, but let's follow the standard coding style at least for new codes. Thanks, Takashi ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642