From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35592C433EF for ; Mon, 14 Feb 2022 07:09:51 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 412A6167C; Mon, 14 Feb 2022 08:08:59 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 412A6167C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1644822589; bh=MUGxuaBoS5+4XYHYmXV6xhCCvfscYnoWRL3ljzsDpd0=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=EksJUc9pnM5LkAUwN69bWp2WKmkkcjWwKxYzBR3LtQRXxVtmJW3N0wjceqt+CwLUK 4cMSh3KncYhFzrhnVghag4JgTEb1lF2OH4FObRGTXrbXuEAagGa5887oS6iingRCc6 n8DNz1utrNeIKTt/zo9780+AKKDBB6TfbyIDCgkA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D23D1F80430; Mon, 14 Feb 2022 08:08:58 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id EDECAF804D1; Mon, 14 Feb 2022 08:08:56 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 67C59F80430 for ; Mon, 14 Feb 2022 08:08:53 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 67C59F80430 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ijTSSOH5"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="biyZHITC" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 7CF10210F5; Mon, 14 Feb 2022 07:08:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1644822532; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2rY4rRZo1qfWGIkhxkIEv83o1WXhDcY8Wef6hSoNe7c=; b=ijTSSOH5msdaUIimuDRnMrasdwFRocg/l6WjbGLiv7ceoGCfncUv7b0gni5jHT29UHf1sG wCYwS6w3ggHXMjDd72jkM6XJWXYG81e2OihSS4LAIkuqgTG6kWXMvWQmgO2toyaGWXzNTw /3iNeIQS2928TUUVXM9w9cljjCmvb7E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1644822532; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2rY4rRZo1qfWGIkhxkIEv83o1WXhDcY8Wef6hSoNe7c=; b=biyZHITCRWvWdIpG78+7JftJw2cyx1BYCa+QbaYVroMr2XyA81/P6C7mYjKhDR7PGPI7xE I26tw0KG8zZAA5Cg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 752D7A3B8A; Mon, 14 Feb 2022 07:08:52 +0000 (UTC) Date: Mon, 14 Feb 2022 08:08:52 +0100 Message-ID: From: Takashi Iwai To: dmummenschanz@web.de Subject: Re: Cannon Lake PCH cAVS (ALC892) not detected by kernel driver In-Reply-To: References: <209270c3-4a46-d6a1-0f1d-d4400ecc5962@linux.intel.com> <2db61794-d772-8df6-a843-fd1512cfaa57@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Pierre-Louis Bossart X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 14 Feb 2022 07:49:55 +0100, dmummenschanz@web.de wrote: > > Thanks for the scoop. I've added "options snd-hda-intel probe_mask=0x105" to / > etc/modules-d/alsa.conf. Unfortunately that didn't help. The ALC892 > didn't show up. Why the log below says "codec_mask forced to 0x5" but I've > explicitly set the value to 0x105 I don't know. The bit 0x100 means to forcibly set the codec probe mask, so this is fine. But the actual work of the forced bit doesn't seem right. Could you try the patch below and test with probe_mask=0x105 again? thanks, Takashi --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -1798,8 +1798,6 @@ static int azx_create(struct snd_card *card, struct pci_dev *pci, assign_position_fix(chip, check_position_fix(chip, position_fix[dev])); - check_probe_mask(chip, dev); - if (single_cmd < 0) /* allow fallback to single_cmd at errors */ chip->fallback_to_single_cmd = 1; else /* explicitly set to single_cmd or not */ @@ -2280,6 +2278,8 @@ static int azx_probe_continue(struct azx *chip) chip->beep_mode = beep_mode[dev]; #endif + check_probe_mask(chip, dev); + /* create codec instances */ if (bus->codec_mask) { err = azx_probe_codecs(chip, azx_max_codecs[chip->driver_type]);