From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCEB9C433EF for ; Sun, 16 Jan 2022 08:22:20 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0CD7F17B3; Sun, 16 Jan 2022 09:21:28 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0CD7F17B3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1642321338; bh=RVr0gCaB8ziUkNGR6RxtSgNniZtv1Ynd/IfG2OmjwEE=; h=Date:From:To:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=qNFMhvJOQMOGe+b2X1ScWd/qHEKkyOqxnFwHBozpImP71o8geVNCdMCISYaSn+q0w 5r2CCzeiMEojuxhMvqiJOabUGvpOiJJNJgpOD+ufoEzfDc9LV2U09FSCFElhhmcXUa X312YS3tzATKsADUuREiivXjs57yZQUlvT3qfdQM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 76425F8047D; Sun, 16 Jan 2022 09:21:27 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CDBBCF804CC; Sun, 16 Jan 2022 09:21:24 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id AF563F80117 for ; Sun, 16 Jan 2022 09:21:18 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz AF563F80117 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Qf5IM3xF"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="ctjlwSos" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 9D30D219A7 for ; Sun, 16 Jan 2022 08:21:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1642321277; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Kh4oanU+m9zAYcgJNtse5kuxOGu3KOuBB4POQ+VHT8Y=; b=Qf5IM3xFxvdl6u+5IGiQbD5sI8+oKJgIpZOzDs/hGLEYDxYtMwO/YvqfTDJxOAIL8yzFyi /rddj/OZ3raf29GJ5+qzC9zcdpqhgq65pBPrXUxADnGVEqkePh0to0sSG3ytEiiMuNShGe /nQTaO5owTJJ6tSE6jyAbZeewuoHSRg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1642321277; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Kh4oanU+m9zAYcgJNtse5kuxOGu3KOuBB4POQ+VHT8Y=; b=ctjlwSos1KHquVb8wC9Rniu/CIZFP5JU/I9uI+/TDmOMc22UqJnJZ5UzJbXReCFdqiXUXF +jhduoldjC5OTlAg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 970A1A3B84 for ; Sun, 16 Jan 2022 08:21:17 +0000 (UTC) Date: Sun, 16 Jan 2022 09:21:17 +0100 Message-ID: From: Takashi Iwai To: alsa-devel@alsa-project.org Subject: Re: [PATCH] ALSA: core: Fix SSID quirk lookup for subvendor=0 In-Reply-To: <20220115090929.4119-1-tiwai@suse.de> References: <20220115090929.4119-1-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, 15 Jan 2022 10:09:29 +0100, Takashi Iwai wrote: > > Some weird devices set the codec SSID vendor ID 0, and > snd_pci_quirk_lookup_id() loop aborts at the point although it should > still try matching with the SSID device ID. This resulted in a > missing quirk for some old Macs. > > Fix the loop termination condition to check both subvendor and > subdevice. > > Fixes: 73355ddd8775 ("ALSA: hda: Code refactoring snd_hda_pick_fixup()") > Cc: > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=215495 > Signed-off-by: Takashi Iwai > --- > sound/core/misc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/core/misc.c b/sound/core/misc.c > index 3579dd7a161f..a512c849a9e5 100644 > --- a/sound/core/misc.c > +++ b/sound/core/misc.c > @@ -112,7 +112,7 @@ snd_pci_quirk_lookup_id(u16 vendor, u16 device, > { > const struct snd_pci_quirk *q; > > - for (q = list; q->subvendor; q++) { > + for (q = list; q->subvendor && q->subdevice; q++) { Doh, a wrong version was sent out. It must be OR instead. Will resubmit v2. Takashi