From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6BE4C433EF for ; Tue, 11 Jan 2022 16:10:22 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C10A6175D; Tue, 11 Jan 2022 17:09:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C10A6175D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1641917419; bh=yzkXGSZiCJmqJC2SqQUoV6NsXo7gv84t4IS/ah+dvIo=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=YCh5Lw1zk/0EvfiuFPSYtS08m5rDPt82RUeWmOH2g8qHGj4dzAoNdAfnPArgsmYuo v7RuCQXZOLMmav4zA/nu//wDgEkTWvFuwW4A9Mnrlf3GkiUUT1qpOcoGwm/ZTA7Oh3 iqqhtVWUxYA5g6QstfNpKmvMb6vqEL28QpNIuLiw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5CBB5F80054; Tue, 11 Jan 2022 17:09:29 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CE371F80054; Tue, 11 Jan 2022 17:09:24 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A5458F80054 for ; Tue, 11 Jan 2022 17:09:18 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A5458F80054 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ZthQwQbW"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="cC1a897i" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 0B79E1F3B8; Tue, 11 Jan 2022 16:09:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1641917358; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q2gg+/L0HZ5tyMQWbHtUsJyCbwGtfjLqKMlD+joksRQ=; b=ZthQwQbW4V4HGZgW6ABIijkgdhpmLua7sHYbombLBY97+tZdeMyIH52yToqOi87OZ3T6+I H98rJmasYI4TsihyC8ezwWuhM26eJRTDLgMvuq54VhKwX9JXYQsM1SkpJchQJ3UXz7f7WH kRwgjETtAd7gbkuC0TyfN2oO4VpwC1s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1641917358; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q2gg+/L0HZ5tyMQWbHtUsJyCbwGtfjLqKMlD+joksRQ=; b=cC1a897iDSVlXNHATuLNT8IYUAjqBHuong6jlzN/TGbV70g4bi+jKsoxsHit8FarQCVoQ9 NcSefpzhh+iP5pCA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id D85B5A3B83; Tue, 11 Jan 2022 16:09:17 +0000 (UTC) Date: Tue, 11 Jan 2022 17:09:17 +0100 Message-ID: From: Takashi Iwai To: Dan Carpenter Subject: Re: [PATCH] ALSA: hda: cs35l41: fix double free on error in probe() In-Reply-To: <20220111072232.GG11243@kili> References: <20220111072232.GG11243@kili> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Lucas Tanure , patches@opensource.cirrus.com, kernel-janitors@vger.kernel.org, Takashi Iwai , James Schulman , David Rhodes X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 11 Jan 2022 08:22:32 +0100, Dan Carpenter wrote: > > If we encounter an error after the kfree(acpi_hw_cfg); then the goto > err; will result in a double free. > > Fixes: 7b2f3eb492da ("ALSA: hda: cs35l41: Add support for CS35L41 in HDA systems") > Signed-off-by: Dan Carpenter Thanks, applied now. Takashi