From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1401FC433ED for ; Wed, 19 May 2021 14:21:53 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFD7261184 for ; Wed, 19 May 2021 14:21:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFD7261184 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 95C08166F; Wed, 19 May 2021 16:20:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 95C08166F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1621434109; bh=R1dmoBDp08tstRXswnXPTvAeMXv4Z/8II6BPZtqetD4=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=OVqFX9GFoXxKohlui0LPUMx+yz3Gv+G4H+CVQgN0qxN1KKmgPYabHK60nRL1PwQQ7 KemKclooxx4D6dTtPJi07Fyuq6xClpxHBVVt9a2AhKqslw2/mISM2ELj6Q6aLrR4v9 AFiHuvAwsW70BYNLIM3gj8etIYWoUlx6KOdCNc0o= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2A1DAF80153; Wed, 19 May 2021 16:20:59 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 93452F8016E; Wed, 19 May 2021 16:20:57 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 78892F80127 for ; Wed, 19 May 2021 16:20:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 78892F80127 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1002BAFB1; Wed, 19 May 2021 14:20:45 +0000 (UTC) Date: Wed, 19 May 2021 16:20:44 +0200 Message-ID: From: Takashi Iwai To: Colin King Subject: Re: [PATCH][next] ALSA: rawmidi: fix incorrect array bounds check on clock_names In-Reply-To: <20210519105424.55221-1-colin.king@canonical.com> References: <20210519105424.55221-1-colin.king@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, David Henningsson , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 19 May 2021 12:54:24 +0200, Colin King wrote: > > From: Colin Ian King > > The array bounds check on clock_names is currently checking the size > of the entire array rather than the number of elements in the array > leading to a potential array bounds read error. Fix this by using > the ARRAY_SIZE macro instead of sizeof. > > Addresses-Coverity: ("Out-of-bounds read") > Fixes: 08fdced60ca0 ("ALSA: rawmidi: Add framing mode") > Signed-off-by: Colin Ian King Thanks, applied. Takashi