From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1748CC54FC9 for ; Tue, 21 Apr 2020 06:10:45 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F58E2076C for ; Tue, 21 Apr 2020 06:10:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="hwKcjt2C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F58E2076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id F028D168C; Tue, 21 Apr 2020 08:09:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz F028D168C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1587449443; bh=OkztQXfhJDDCUVX/J4wTOz55u6VICW9XEm0IEMDHRsw=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=hwKcjt2CeWuR4wJduurVdAlML7y52KYNBKnnOVatsxwxo2DuOp8+mNQSV/xWDYmRZ H0WONz0/lYwPSu6rg9fJn3aOBfumj5sB4AFC+G05hfo1Syav8S25eJiZwmSail3rh6 98ItpnDskLklaziTZ3GvgkgVC+uZBWeX7HtaD+RI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B94ECF80143; Tue, 21 Apr 2020 08:06:44 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 84CFAF801EC; Tue, 21 Apr 2020 08:06:37 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2E039F800FF for ; Tue, 21 Apr 2020 08:06:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2E039F800FF X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 9EEF0AA55; Tue, 21 Apr 2020 06:06:32 +0000 (UTC) Date: Tue, 21 Apr 2020 08:06:32 +0200 Message-ID: From: Takashi Iwai To: Gregor Pintar Subject: Re: [PATCH v2] ALSA: usb-audio: Add quirk for Focusrite Scarlett 2i2 In-Reply-To: <20200420214030.2361-1-grpintar@gmail.com> References: <1c4b8a362761421eba0ded60bb4f0e11b7e42f3b.camel@tsoy.me> <20200420214030.2361-1-grpintar@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: linux-kernel@vger.kernel.org, alexander@tsoy.me, tiwai@suse.com, alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 20 Apr 2020 23:40:30 +0200, Gregor Pintar wrote: > > Force it to use asynchronous playback. > > Same quirk has already been added for Focusrite Scarlett Solo (2nd gen) > with a commit 46f5710f0b88 ("ALSA: usb-audio: Add quirk for Focusrite > Scarlett Solo"). > > This also seems to prevent regular clicks when playing at 44100Hz > on Scarlett 2i2 (2nd gen). I did not notice any side effects. > > Moved both quirks to snd_usb_audioformat_attributes_quirk() as suggested. > > Signed-off-by: Gregor Pintar Applied it now to for-linus branch. thanks, Takashi