From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D169EC2BD09 for ; Fri, 6 Dec 2019 15:46:31 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6048D20659 for ; Fri, 6 Dec 2019 15:46:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="J8tYMhPW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6048D20659 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7739B1673; Fri, 6 Dec 2019 16:45:39 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7739B1673 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1575647189; bh=5sdwVWdHyFPFSwJmM1lpEPqXzwroIV3fsY/KSzQDrCE=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=J8tYMhPWY9OLiaB3FQdP0xzbLPgXUlASpfOUr5ev51KaH7zMaNFjhQAzVcOsQCff2 H09KkG5LqxTYXqX/9rEprpaVy/oknjtYUv3OBqMTg06K2siXceq18iOOrg243qISF1 HOu2RaLiK5JyLZ5rU33lCH5yk9e2A/EpvQuAo2Ww= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id EF221F801D9; Fri, 6 Dec 2019 16:45:38 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1A9D9F801EC; Fri, 6 Dec 2019 16:45:37 +0100 (CET) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5EF94F8010F for ; Fri, 6 Dec 2019 16:45:33 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5EF94F8010F X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C7D27AC35; Fri, 6 Dec 2019 15:45:32 +0000 (UTC) Date: Fri, 06 Dec 2019 16:45:32 +0100 Message-ID: From: Takashi Iwai To: Pierre-Louis Bossart In-Reply-To: <30321a90-a6fa-4f25-c02a-24ac9aa69709@linux.intel.com> References: <20191206013413.237576-1-cujomalainey@chromium.org> <30321a90-a6fa-4f25-c02a-24ac9aa69709@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org, Jie Yang , Cezary Rojewski , Liam Girdwood , Mac Chiang , Bard Liao , Bard liao , Jenny TC , Krzysztof Kozlowski , Hui Wang , Jon Flatley , Alexios Zavras , Mark Brown , Christophe JAILLET , Naveen Manohar , Thomas Gleixner , Kai Vehmanen , Ben Zhang , Takashi Iwai , Sathya Prakash M R , Curtis Malainey Subject: Re: [alsa-devel] [PATCH v3] ASoC: intel: Add Broadwell rt5650 machine driver X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 06 Dec 2019 16:31:20 +0100, Pierre-Louis Bossart wrote: > > > > On 12/5/19 7:34 PM, Curtis Malainey wrote: > > From: Ben Zhang > > > > Add machine driver for Broadwell + rt5650. > > > > Signed-off-by: Bard Liao > > Signed-off-by: Ben Zhang > > Signed-off-by: Mac Chiang > > Signed-off-by: Jon Flatley > > Signed-off-by: Curtis Malainey > > sounds good, but it'd be nice to fix the Sparse warning below > > bdw-rt5650.c:102:37: warning: incorrect type in argument 2 (different > base types) > bdw-rt5650.c:102:37: expected unsigned int val > bdw-rt5650.c:102:37: got restricted snd_pcm_format_t [usertype] > > We introduced a new function to deal with this, can't recall off the > top of my head. It's snd_mask_set_format(). The open code in this patch snd_mask_set(¶ms->masks[SNDRV_PCM_HW_PARAM_FORMAT - SNDRV_PCM_HW_PARAM_FIRST_MASK], SNDRV_PCM_FORMAT_S24_LE); is replaced with snd_mask_set_format(hw_param_mask(params, SNDRV_PCM_HW_PARAM_FORMAT), SNDRV_PCM_FORMAT_S24_LE); Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel