From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [alsa-devel] [PATCH] ALSA: firewire: fix a memory leak bug Date: Thu, 08 Aug 2019 11:12:49 +0200 Message-ID: References: <1565243458-2771-1-git-send-email-wenwen@cs.uga.edu> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Takashi Sakamoto Cc: Wenwen Wang , "moderated list:FIREWIRE AUDIO DRIVERS" , Clemens Ladisch , Takashi Iwai , open list List-Id: alsa-devel@alsa-project.org On Thu, 08 Aug 2019 11:04:03 +0200, Takashi Sakamoto wrote: > > Hi, > > On Thu, Aug 8, 2019, at 14:53, Wenwen Wang wrote: > > In iso_packets_buffer_init(), 'b->packets' is allocated through > > kmalloc_array(). Then, the aligned packet size is checked. If it is > > larger than PAGE_SIZE, -EINVAL will be returned to indicate the error. > > However, the allocated 'b->packets' is not deallocated on this path, > > leading to a memory leak. > > > > To fix the above issue, free 'b->packets' before returning the error code. > > > > Signed-off-by: Wenwen Wang > > --- > > sound/firewire/packets-buffer.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Takashi Sakamoto > > And this bug exists till its first commit for v2.6.39. > > Fixes: 31ef9134eb52 ("ALSA: add LaCie FireWire Speakers/Griffin FireWave Surround driver") > Cc: # v2.6.39+ Applied, thanks. Takashi