From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: bug: reconfig broken on kernel 4.5
Date: Tue, 10 May 2016 12:15:52 +0200
Message-ID: <s5hfutqnrqf.wl-tiwai@suse.de>
References: <1462782169.3239.12.camel@maxwell> <s5hlh3jpbh9.wl-tiwai@suse.de>
 <s5h4ma6b985.wl-tiwai@suse.de> <1462873676.10277.16.camel@maxwell>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 1B58726578F
 for <alsa-devel@alsa-project.org>; Tue, 10 May 2016 12:15:53 +0200 (CEST)
In-Reply-To: <1462873676.10277.16.camel@maxwell>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Jochen Henneberg <jh@henneberg-systemdesign.com>
Cc: alsa-devel <alsa-devel@alsa-project.org>
List-Id: alsa-devel@alsa-project.org

On Tue, 10 May 2016 11:47:56 +0200,
Jochen Henneberg wrote:
> 
> On Di, 2016-05-10 at 10:36 +0200, Takashi Iwai wrote:
> > On Mon, 09 May 2016 16:11:46 +0200,
> > Takashi Iwai wrote:
> > > 
> > > On Mon, 09 May 2016 10:22:49 +0200,
> > > Jochen Henneberg wrote:
> > > > 
> > > > Hi,
> > > > 
> > > > it looks as if 'reconfig' feature is broken since the sysfs attributes
> > > > have been moved to device attributes. In hda_sysfs.c:reconfig_codec()
> > > > the device is cleared with snd_hda_codec_reset() which calls
> > > > snd_hdac_device_unregister() which removes the sysfs entries (including
> > > > the currently in-use 'reconfig'), the re-registration fails afterwards
> > > > in snd_hda_codec_build_controls().
> > > > I am not sure when things got broken, but snd_hda_codec_reset()
> > > > called from reconfig_codec() unregisters the device and removes the
> > > > sysfs entries where in the past it only stripped all configurations
> > > > (pcms, controls ...) from the device.
> > > 
> > > Hrm, OK, something got broken indeed there.  I'll check it later.
> > 
> > Actually it's not about the sysfs, but rather the superfluous calls of
> > snd_hda_codec_build_controls() & co.  The fix patch is below.
> > 
> 
> Sorry for the confusion, I did not notice. Anyway, I have tested the
> patch with 4.5, changed codec hints, reconfig and no error messages and
> the changed hints have been respected after reconfig, looks good for me.

The patch has been merged now.


thanks,

Takashi