From: Takashi Iwai <tiwai@suse.de>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 5/5] snd-ice1712: Fix resume on ice1724
Date: Wed, 31 Oct 2012 08:29:36 +0100 [thread overview]
Message-ID: <s5hfw4vt7z3.wl%tiwai@suse.de> (raw)
In-Reply-To: <201210302034.00890.linux@rainbow-software.org>
At Tue, 30 Oct 2012 20:34:00 +0100,
Ondrej Zary wrote:
>
> On Wednesday 17 October 2012 08:57:39 Takashi Iwai wrote:
> > At Sun, 14 Oct 2012 21:09:23 +0200,
> >
> > Ondrej Zary wrote:
> > > set_pro_rate() is called from hw_params() but not from prepare(),
> > > breaking running PCM on suspend/resume. Call it from prepare() if PCM was
> > > suspended to fix the problem.
> > >
> > > Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
> >
> > This should be fixed in the resume callback. Could you check the
> > patch below instead?
>
> I've now verified that this patch fixes a real problem. When "multi track rate
> locking" is disabled and some sound is played at non-default (non-48kHz)
> frequency during suspend, the frequency is wrong (48kHz) after resume. This
> patch fixes that.
OK, the patch was applied now. Thanks for checking.
Takashi
next prev parent reply other threads:[~2012-10-31 7:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 19:34 [alsa-devel] [PATCH 5/5] snd-ice1712: Fix resume on ice1724 Ondrej Zary
2012-10-31 7:29 ` Takashi Iwai [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-10-14 19:09 [PATCH 0/5] snd-ice1712: Add Philips PSC724 Ultimate Edge Ondrej Zary
2012-10-14 19:09 ` [PATCH 5/5] snd-ice1712: Fix resume on ice1724 Ondrej Zary
2012-10-17 6:57 ` Takashi Iwai
2012-10-18 22:02 ` [alsa-devel] " Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hfw4vt7z3.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).