From: Takashi Iwai <tiwai@suse.de>
To: Tarek Soliman <tarek@bashasoliman.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: usb-audio: define another USB ID for a buggy USB MIDI cable
Date: Wed, 06 Apr 2011 08:06:22 +0200 [thread overview]
Message-ID: <s5hfwpvrk0x.wl%tiwai@suse.de> (raw)
In-Reply-To: <20110406023512.GA29973@zeus.olympus>
At Tue, 5 Apr 2011 21:35:12 -0500,
Tarek Soliman wrote:
>
> On Mon, Apr 04, 2011 at 09:23:53AM -0500, Tarek Soliman wrote:
> > There are many USB MIDI cables out there that have buggy
> > firmware that reports it can do more than 4 bytes in a
> > packet when they can only properly handle 4
> >
> > This patch adds the ID of yet another one of those cables
> >
> > Signed-off-by: Tarek Soliman <tarek@bashasoliman.com>
> > ---
> > sound/usb/midi.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/sound/usb/midi.c b/sound/usb/midi.c
> > index b4b39c0..f928910 100644
> > --- a/sound/usb/midi.c
> > +++ b/sound/usb/midi.c
> > @@ -1301,6 +1301,7 @@ static int snd_usbmidi_out_endpoint_create(struct snd_usb_midi* umidi,
> > case USB_ID(0x15ca, 0x0101): /* Textech USB Midi Cable */
> > case USB_ID(0x15ca, 0x1806): /* Textech USB Midi Cable */
> > case USB_ID(0x1a86, 0x752d): /* QinHeng CH345 "USB2.0-MIDI" */
> > + case USB_ID(0xfc08, 0x0101): /* Unknown vendor Cable */
> > ep->max_transfer = 4;
> > break;
> > /*
> > --
> > 1.7.4.1
> >
> > As instructed, I updated the insertion point of the new entry such
> > that the entries are sorted.
>
> Hi,
>
> Is there anything else required for this to be merged?
> I am very new to this.
Your new patch is fine. I applied it now.
Thanks!
Takashi
next prev parent reply other threads:[~2011-04-06 6:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 14:23 [PATCH] ALSA: usb-audio: define another USB ID for a buggy USB MIDI cable Tarek Soliman
2011-04-06 2:35 ` Tarek Soliman
2011-04-06 6:06 ` Takashi Iwai [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-04-03 6:51 Tarek Soliman
2011-04-04 9:18 ` Takashi Iwai
2011-04-04 14:26 ` Tarek Soliman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hfwpvrk0x.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=tarek@bashasoliman.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).