From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] ALSA: usb-audio: define another USB ID for
	a buggy USB MIDI cable
Date: Wed, 06 Apr 2011 08:06:22 +0200
Message-ID: <s5hfwpvrk0x.wl%tiwai@suse.de>
References: <20110404142353.GA3821@zeus.olympus>
	<20110406023512.GA29973@zeus.olympus>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx1.suse.de (cantor.suse.de [195.135.220.2])
	by alsa0.perex.cz (Postfix) with ESMTP id A176310382D
	for <alsa-devel@alsa-project.org>;
	Wed,  6 Apr 2011 08:06:25 +0200 (CEST)
In-Reply-To: <20110406023512.GA29973@zeus.olympus>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Tarek Soliman <tarek@bashasoliman.com>
Cc: alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

At Tue, 5 Apr 2011 21:35:12 -0500,
Tarek Soliman wrote:
> 
> On Mon, Apr 04, 2011 at 09:23:53AM -0500, Tarek Soliman wrote:
> > There are many USB MIDI cables out there that have buggy
> > firmware that reports it can do more than 4 bytes in a
> > packet when they can only properly handle 4
> > 
> > This patch adds the ID of yet another one of those cables
> > 
> > Signed-off-by: Tarek Soliman <tarek@bashasoliman.com>
> > ---
> >  sound/usb/midi.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/sound/usb/midi.c b/sound/usb/midi.c
> > index b4b39c0..f928910 100644
> > --- a/sound/usb/midi.c
> > +++ b/sound/usb/midi.c
> > @@ -1301,6 +1301,7 @@ static int snd_usbmidi_out_endpoint_create(struct snd_usb_midi* umidi,
> >  	case USB_ID(0x15ca, 0x0101): /* Textech USB Midi Cable */
> >  	case USB_ID(0x15ca, 0x1806): /* Textech USB Midi Cable */
> >  	case USB_ID(0x1a86, 0x752d): /* QinHeng CH345 "USB2.0-MIDI" */
> > +	case USB_ID(0xfc08, 0x0101): /* Unknown vendor Cable */
> >  		ep->max_transfer = 4;
> >  		break;
> >  		/*
> > -- 
> > 1.7.4.1
> > 
> > As instructed, I updated the insertion point of the new entry such
> > that the entries are sorted.
> 
> Hi,
> 
> Is there anything else required for this to be merged?
> I am very new to this.

Your new patch is fine.  I applied it now.
Thanks!


Takashi